Fix #70 #72
Closed
Fix #70 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnapoli
added a commit
to mnapoli/externals
that referenced
this pull request
Aug 1, 2020
mnapoli
added a commit
to mnapoli/externals
that referenced
this pull request
Aug 1, 2020
|
Well, it works but with some luck. If you somehow manage to follow all those states you'll see that this code should be added in the Once I push the changes I'll close this PR. |
|
Here is the commit 45de0e3 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have taken #71 which was closed and added a test to cover the question asked in the comments (it seems to work fine).
Hopefully that helps fixing this bug.
cc @andytruong, I built my PR on top of yours and kept your commit.