Fixed an exception when SongCore is not installed. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. |
opl-
added a commit
that referenced
this pull request
Sep 7, 2021
Changes: - Support for Beat Saber v1.17.0 (#73, by @ErisApps) - `beatmap.difficulty` now represents the name of the difficulty in the game's current language. If SongCore is installed, this value may contain the custom difficulty name defined by the beatmap, however I've not actually seen that happen. (#70) - The mod now targets .NET v4.7.2 Fixes: - Exception thrown when SongCore is not installed while extracting value for `beatmap.songHash`. (#69, by @rynan4818)
opl-
added a commit
that referenced
this pull request
Sep 7, 2021
Changes: - Support for Beat Saber v1.17.0 (#73, by @ErisApps) - `beatmap.difficulty` now represents the name of the difficulty in the game's current language. If SongCore is installed, this value may contain the custom difficulty name defined by the beatmap, however I've not actually seen that happen. (#70) - The mod now targets .NET v4.7.2 Adds: - `beatmap.difficultyEnum` representing the internal beatmap difficulty enum. See [protocol.md] for more information. Fixes: - Exception thrown when SongCore is not installed while extracting value for `beatmap.songHash`. (#69, by @rynan4818)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for the following pull request was found to cause an
ArgumentOutOfRangeExceptionexception when SongCore is not installed.https://github.com/opl-/beatsaber-http-status/pull/44
If SongCore is not installed,
songHashinlevelIDwill be the folder name of the map.However, since there are few environments that do not have SongCore installed, I think the problem will occur in few cases.