1.17.0 Compatibility #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It got renamed
ErisApps
force-pushed
the
bugfix/1.17_Compatibility
branch
from
7d18b21
to
4747bf8
Compare
opl-
added a commit
that referenced
this pull request
Sep 7, 2021
Changes: - Support for Beat Saber v1.17.0 (#73, by @ErisApps) - `beatmap.difficulty` now represents the name of the difficulty in the game's current language. If SongCore is installed, this value may contain the custom difficulty name defined by the beatmap, however I've not actually seen that happen. (#70) - The mod now targets .NET v4.7.2 Fixes: - Exception thrown when SongCore is not installed while extracting value for `beatmap.songHash`. (#69, by @rynan4818)
opl-
added a commit
that referenced
this pull request
Sep 7, 2021
Changes: - Support for Beat Saber v1.17.0 (#73, by @ErisApps) - `beatmap.difficulty` now represents the name of the difficulty in the game's current language. If SongCore is installed, this value may contain the custom difficulty name defined by the beatmap, however I've not actually seen that happen. (#70) - The mod now targets .NET v4.7.2 Adds: - `beatmap.difficultyEnum` representing the internal beatmap difficulty enum. See [protocol.md] for more information. Fixes: - Exception thrown when SongCore is not installed while extracting value for `beatmap.songHash`. (#69, by @rynan4818)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed renamed property reference. It got renamed in the 1.17.0 BS update (fixes #72 supposedly)
You still need to bump versions and such though.