Gateways, empty gateway_group tag in config.xml being parsed in getGr…

…oups() results. fix a bit of spacing while here. closes #3576
opnsense · Jul 17, 2019 · 5dca5cc · 5dca5cc
1 parent dd02e21
commit 5dca5cc
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/opnsense/mvc/app/library/OPNsense/Routing/Gateways.php b/src/opnsense/mvc/app/library/OPNsense/Routing/Gateways.php
@@ -389,11 +389,11 @@ public function getInterfaceGateway($interface, $ipproto = "inet")
      */
     public function getGroups($status_info)
     {
-          $all_gateways = $this->gatewaysIndexedByName();
-          $result = array();
+        $all_gateways = $this->gatewaysIndexedByName();
+        $result = array();
         if (isset($this->configHandle->gateways)) {
             foreach ($this->configHandle->gateways->children() as $tag => $gw_group) {
-                if ($tag == "gateway_group") {
+                if ($tag == "gateway_group" && !empty($gw_group)) {
                     $tiers = array();
                     if (isset($gw_group->item)) {
                         foreach ($gw_group->item as $item) {
@@ -453,7 +453,7 @@ public function getGroups($status_info)
                 }
             }
         }
-          return $result;
+        return $result;
     }
 
     /**