Skip to content

Commit

Permalink
firewall: groups were not correctly parsed for menu post-migration
Browse files Browse the repository at this point in the history
  • Loading branch information
fichtner committed Aug 1, 2023
1 parent b5992b8 commit b52bf63
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ public function __construct()
/* we need both if and gr reference */
$iftargets['if'][(string)$node->ifname] = (string)$node->ifname;
$iftargets['gr'][(string)$node->ifname] = (string)$node->ifname;
foreach (explode(' ', (string)$node->members) as $member) {
foreach (preg_split('/[ |,]+/', (string)$node->members) as $member) {
if (!array_key_exists($member, $ifgroups)) {
$ifgroups[$member] = [];
}
Expand Down

2 comments on commit b52bf63

@ValliereMagic
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@fichtner
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ValliereMagic no worries, appreciate all the quick reports

Please sign in to comment.