gwlb, gateway switch shouldn't be in the for loop

opnsense · May 8, 2017 · ce8ef99 · ce8ef99
1 parent 9d23933
commit ce8ef99
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/etc/inc/gwlb.inc b/src/etc/inc/gwlb.inc
@@ -738,14 +738,16 @@ function fixup_default_gateway($gateways_status, $gateways_arr)
                 if (empty($upgw) && $gwsttng[$gwname]['friendlyiface'] != "lan" &&
                   (isset($gwsttng['monitor_disable']) || !stristr($gateways_status[$gwname]['status'], "down"))) {
                     $upgw = $gwname;
-                }
-                if (!$dfltgwup && !empty($upgw)) {
-                    // switch gateway
-                    $dfltgwname = $upgw;
-                    break;
+                    if (!$dfltgwup) {
+                        break;
+                    }
                 }
             }
         }
+        if (!$dfltgwup && !empty($upgw)) {
+            // switch gateway
+            $dfltgwname = $upgw;
+        }
         if ($gateways_arr[$dfltgwname]['gateway'] == "dynamic") {
             if ($ipprotocol == 'inet') {
                 $gwip = get_interface_gateway($gateways_arr[$dfltgwname]['friendlyiface']);