Interfaces: Diagnostics: Ping - minor adjustments for #6378, limit th…

…e maximum runtime to a day, fix form help an add source address

src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/forms/ping.xml

@@ -20,7 +20,7 @@
        <id>ping.settings.packetsize</id>
        <label>Packet size</label>
        <type>text</type>
-       <help><![CDATA[Specify the number of data bytes to be sent.]]></help>
+       <help>Specify the number of data bytes to be sent. Keep in mind this is the payload size, an IP and ICMP header are added.</help>
     </field>
     <field>
       <id>ping.settings.disable_frag</id>
@@ -29,7 +29,6 @@
       <help>
       Disable fragmentation.
       Can be helpful to determine the maximum size a transport is able to send.
-      Keep in mind this is the payload size, an IP and ICMP header are added.
       </help>
     </field>
     <field>

src/opnsense/scripts/interfaces/ping.py

@@ -161,8 +161,12 @@ def read_latest_stats(filename):
                 '-p', "%s%s.pid" % (TEMP_DIR, cmd_args.job),
                 '-t',  'ping_%s' % cmd_args.job,
                 '/sbin/ping',
+                '-c', '86400', # hard limit: stop after 1 day
                 '-4' if settings.get('fam', 'ip') == 'ip' else '-6'
             ]
+            if settings.get('source_address', '') != '':
+                args.append('-S')
+                args.append(settings['source_address'])
             if settings.get('packetsize', '') != '':
                 args.append('-s')
                 args.append(settings['packetsize'])