dashboard: sidebar menu

[fichtner]

• deselect icon after click
• change gyphicons to fontawesome icons
• on MVC pages the toggle is reversed after page load 18.7 release - sidebar problem #2596
• support default theme Opnsense_theme_patch #2555
• wrong colours in default theme wrong colors opnsense sidebar theme #2601
• save preference in local session (people will complain if it's not sticky)
• footer gap on minified view 18.7 - 19.1 -> Tested opnsense original theme with new sidebar -> still 1 problem found #2626
• toggle disappears (in Chrome) when developer tools are open -- due to height requirement, fix resize back to original preference New Sidebar -> on viewport height resize (lower then 669px) -> do not switch back! #2628
• delay / click behaviour (hover should probably trigger menu instantly) Sidebar/hover - modification #2727
• tooltips for full/minified button toggle tooltip for sidebar #2742
• presentation: scrap transparency in the overlay Opnsense theme sidebar mod #2755
• proportions: logos vs. submenus is too drastic
• remove expansion delay / animation
• hover in and out resets same elements instead of reopening them
• sticky sub-submenu on mouseout when next item does not have a sub-submenu sticky sub-submenu #2782
• positioning of submenu may be cropped due to small height sidebar - submenu may be cropped due to small height (fix) #2865

[marjohn56]

Default theme #2555

[fichtner]

@opnsenseuser you can push all your notes here... we don't need at ticket for each issue :)

[opnsenseuser]

@franco font-size, color, (no transparent) and hover modification!

#2728

[opnsenseuser]

@franco .js hover update
#2727

[opnsenseuser]

@franco tooltip for sidebar
#2742

[fichtner]

@opnsenseuser thanks, I'll merge this over the weekend when I have a clear head for this :)

[opnsenseuser]

@franco great thx. Please its also Important to merge all themes. Like opnsense, cicada, tukan and the dark theme. All pr‘s are already done! Thx , regards rene

[opnsenseuser]

@franco have now cleaned up both themes (tukan and cicada) completely and as Martin all tokenize2 and nv.d3 - css stuff divided into seperate files. besides, I've tried correcting all tabs and wrong spaces. It took a lot of effort, but I wanted to make fabian a pleasure. He was right, but I had no time for it so far. Greetings René... hope you can merge it soon!!! thx - nice day!!

[fichtner]

@opnsenseuser almost done :)

What do you think about 14px for the menu font? I'm also pondering about the click behaviour that undoes the "transition" effect. If we had it open instantly the click to remove would feel more natural. Right now it opens and habit clicks which makes the opening menu disappear again.

What do you think?

[opnsenseuser]

@franco

the font-size on 14px is okay. the problem is the submenu.
if it is too high it would be outside the viewports.
Then you could only do it as the dropdown menus work -> go up if there is not enough space.
If there was no space here then we would face another problem.
Freenas simply added a scroll bar to each submenu and set the height of the submenu to a fixed value.
I think that's not very user friendly and looks very strange.

It is not easy to find a really good solution.
In any case, we already have a very good starting point on which we can build.
I have to think about it.

Interesting would be the opinion of Fabian or others. Ideas are always good.

[opnsenseuser]

@fichtner
I do not know if that is possible but would be very interesting to do a survey. and everyone who tests the sidebar to ask what bothers them or what they would like. I do not know if that's possible. I always find the other's feedback very interesting!

[fichtner]

sure, you can make a survey for the plugin theme users (cicada, rebellion, tukan). we'll release the current state for those in 18.7.4. the default theme needs some extra care for compatibility testing later on, but there's time for that.

[opnsenseuser]

@fichtner Because of your second question I wanted to ask you again.
Did I understand correctly that you can imagine with one click the submenu to close?
So the click event should be limited to running menu items and closing the submenu? Is this correct?

[fichtner]

@opnsenseuser the clicks work fine, but when it's still expanding on hover and you click it removes the opening menu

[opnsenseuser]

@fichtner ok. I'll take a look. :-)

[fichtner]

indeed, that bug seems to be back. thanks for spotting it :) expand up is ok, though?

[opnsenseuser]

I can only Test in the evening.

[opnsenseuser]

Could be old bug Problem or Cache (Firewall,Browser) and so on....

[opnsenseuser]

I know that it should work. Tested it on all themes

[opnsenseuser]

Tested it On the latest 19.1 Version yesterday

[opnsenseuser]

Only real Problem i know is the memory or cpu demand of jquery. Therefore i need help

[opnsenseuser]

Also could be, that the Orginal theme has the wrong z-Index set for Submenus. It should overlab the Head div.

[opnsenseuser]

@fichtner
@mimugmail
yes, unfortunately .... you have too many elements, the space is not enough. Some things can be solved, but some unfortunately not. I think we can not avoid the scrollbar!

maybe the solution in such a case would be to downsize the font. This would also reduce the div levels.
whether one can dazzle the submenu above the header, I must first determine. Since we work here partially with fixed positions, it seems to be difficult.

z-index description:
Items can have only one z-index if they have an item of position that differs from static or if they are flex-items

[opnsenseuser]

We can also consider, if the div is too long to switch back to the standard navigation!

[opnsenseuser]

@fichtner did you Test it. Is there a bug you wrote?

[opnsenseuser]

@fichtner
@mimugmail i have a solution for the "cut off" problem and will post this soon!

[opnsenseuser]

@fichtner
@mimugmail
solution:

[mimugmail]

If you want me to test just tell me your repo/branch :)

[opnsenseuser]

@fichtner
@mimugmail

opnsense theme mod (cut off problem fix)
#2869

tukan cicada theme mod (cut off problem fix)
opnsense/plugins#953

[opnsenseuser]

@mimugmail would be great if you could test this! regards rené

[opnsenseuser]

@fichtner
@mimugmail
sidebar - fix for some problems with sticky sub-submenu:
#2872

[opnsenseuser]

i´m really proud of the last mods i did for sidebar and all themes. it looks and feels much much better now

[opnsenseuser]

I hope to see the mods at least for tukan and cicada in the next release. Thank you, best regards, René

[opnsenseuser]

@fichtner it would at least be important to merge the newest javascript as it fixes a major scrolling issue. best regards rené

[fichtner]

There's one small bug that I see if you install "vnstat" plugin. In the service menu, go to "web proxy", then move mouse up to "vnstat". "web proxy" is still extended and not closed. The other way around into "vnstat" seems to do that correctly for "unbound dns".

[opnsenseuser]

@fichtner thanks franco, i know i have been searching for this error for some days now. there is no apparent reason why this occurs. but I am working on it and will solve it as soon as possible. I still hope that you are satisfied with the work so far. best regards, rene

[fichtner]

yes, no worries, this is great work. just turns out to be very difficult to make it perfect 👍

[fabianfrz]

@fichtner the todo list is completed. Close?

[opnsenseuser]

👍

[fichtner]

ok, sure, thanks everyone ❤️

[opnsenseuser]

As I completed my first project with today's final public relations sidebar (#2877), I'm looking for a new challenge.
You may now know about my level of knowledge.
I would be very happy about every new task. There is still much to do and I am full of energy.

Thanks again for your support in all matters!

René

[fabianfrz]

@opnsenseuser if you don't have an idea what you can improve, you can work on the docs as well. Users often ask for a chapter about the firewall section for example.

[opnsenseuser]

@fabianfrz I know, but I do not really feel at home.
When it comes to graphic work, I am always at your service!
Currently I imagine to make a kind of standard "Error / Info" proxy page or a default template for the captive portal. Something in the direction would be of great interest.

[opnsenseuser]

There's one small bug that I see if you install "vnstat" plugin. In the service menu, go to "web proxy", then move mouse up to "vnstat". "web proxy" is still extended and not closed. The other way around into "vnstat" seems to do that correctly for "unbound dns".

fix -> #2877