Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System: Settings: Logging: merge into Logging / Targets page #6830

Closed
2 tasks done
fichtner opened this issue Sep 7, 2023 · 1 comment
Closed
2 tasks done

System: Settings: Logging: merge into Logging / Targets page #6830

fichtner opened this issue Sep 7, 2023 · 1 comment
Assignees
@fichtner
Labels
feature Adding new functionality roadmap Major roadmap item
Milestone
24.7

Comments

@fichtner
Copy link
Member

fichtner commented Sep 7, 2023

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

Is your feature request related to a problem? Please describe.

The pages both try to do the same, but one is for remote the other one is for local.

Describe the solution you like

Migrate settings into model and reuse the existing MVC page. This one can be renamed then.

Describe alternatives you considered

N/A

Additional context

N/A
@fichtner fichtner added the feature Adding new functionality label Sep 7, 2023
@fichtner fichtner added this to the 24.1 milestone Sep 7, 2023
@fichtner fichtner self-assigned this Sep 7, 2023
@AdSchellevis AdSchellevis modified the milestones: 24.1, 24.7 Jan 3, 2024
@fichtner fichtner added the roadmap Major roadmap item label Feb 15, 2024
fichtner added a commit that referenced this issue Feb 28, 2024
@fichtner
system: move syslog reset function to system include #6830
5247ab3
fichtner added a commit that referenced this issue Feb 28, 2024
@fichtner
system: move web GUI error log setting to appropriate page #6830
d5b84cf 
The storage location is wrong but deal with this later.
fichtner added a commit that referenced this issue Feb 28, 2024
@fichtner
system: move firewall log settings to advanced firewall #6830
98aabba
fichtner added a commit that referenced this issue Feb 28, 2024
@fichtner
system: fix PHP warnings related to #6830
6bc7903
fichtner added a commit that referenced this issue Feb 29, 2024
@fichtner
system: WIP for moving settings over #6830
2900f70
fichtner added a commit that referenced this issue Feb 29, 2024
@fichtner
system: fix use after migration #6830
8ea6e7b
fichtner added a commit that referenced this issue Feb 29, 2024
@fichtner
system: fix templating for loglocal #6830
4c78d5b
fichtner added a commit that referenced this issue Mar 1, 2024
@fichtner
system: remove the old syslog logging page #6830
945bd66 
New tab is still to be added to the MVC page.  Move it in place
for now and deal with nagivgation and wording later.
fichtner added a commit that referenced this issue Mar 1, 2024
@fichtner
system: add local settings tab (read only) to logging #6830
ed1bd09
fichtner added a commit that referenced this issue Mar 1, 2024
@fichtner
system: appropriate GUI styling and functional save #6830
6f9fc2d
fichtner added a commit that referenced this issue Mar 1, 2024
@fichtner
system: patch in reset option #6830
006be3a
@fichtner
Copy link
Member Author

fichtner commented Mar 1, 2024

Last but not least check documentation and see if we can remove "Destinations" to "Remote".

fichtner added a commit that referenced this issue Mar 4, 2024
@fichtner
system: switch "destination" tab to "remote" for consistency #6830
b588ded
fichtner added a commit to opnsense/docs that referenced this issue Mar 4, 2024
@fichtner
manual: adjust for syslog settings merge
7e370a8 
Also remove a bit of clutter from the text and adjust GUI labels
slightly where the text was mismatching plus fill the gap of missing
option max file size.

PR: opnsense/core#6830
@fichtner fichtner closed this as completed Mar 4, 2024
fichtner added a commit that referenced this issue Mar 12, 2024
@fichtner
system: move syslog reset function to system include #6830
1a661a9
fichtner added a commit that referenced this issue Mar 12, 2024
@fichtner
system: move web GUI error log setting to appropriate page #6830
043e1cd 
The storage location is wrong but deal with this later.
fichtner added a commit that referenced this issue Mar 12, 2024
@fichtner
system: move firewall log settings to advanced firewall #6830
fde50be
fichtner added a commit that referenced this issue Mar 12, 2024
@fichtner
system: fix PHP warnings related to #6830
1b6e3e1
fichtner added a commit that referenced this issue Mar 12, 2024
@fichtner
system: WIP for moving settings over #6830
695bfe2
fichtner added a commit that referenced this issue Mar 12, 2024
@fichtner
system: fix use after migration #6830
6170428
fichtner added a commit that referenced this issue Mar 12, 2024
@fichtner
system: fix templating for loglocal #6830
9686f21
fichtner added a commit that referenced this issue Mar 12, 2024
@fichtner
system: remove the old syslog logging page #6830
f9c4e88 
New tab is still to be added to the MVC page.  Move it in place
for now and deal with nagivgation and wording later.
fichtner added a commit that referenced this issue Mar 12, 2024
@fichtner
system: add local settings tab (read only) to logging #6830
d17f2b6
fichtner added a commit that referenced this issue Mar 12, 2024
@fichtner
system: appropriate GUI styling and functional save #6830
1b60d28
fichtner added a commit that referenced this issue Mar 12, 2024
@fichtner
system: patch in reset option #6830
a58284a
fichtner added a commit that referenced this issue Mar 12, 2024
@fichtner
system: switch "destination" tab to "remote" for consistency #6830
70fc765
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fichtner fichtner

Labels
feature Adding new functionality roadmap Major roadmap item
Milestone
24.7
Development

No branches or pull requests
2 participants
@fichtner @AdSchellevis