Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unbound: Add support for DoH and DoT #5468

Closed
wants to merge 1 commit into from

Conversation

schreibubi
Copy link

Add support for unbound to act as an DoH and DoT server

image

Added additional values to the unbound statistics page which allow to
monitor DoH and DoT query count.

image

Fixes #5104

Additional commit will be necessary to add the automation to restart unbound when the Acme certificate changes. Will submit a separate PR for that.

@schreibubi
Copy link
Author

Corresponding acme-client automation PR: opnsense/plugins#2747

$dohdot_settings = '';
if (isset($config['unbound']['enable_doh']) || isset($config['unbound']['enable_dot'])) {
$cert =& lookup_cert($config['unbound']['dohdot_cert']);
$chain = [];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation on this and some following lines should be improved IMHO. From indentation I think the lines 356 & 357 are inside the if block. From the parenthesis these lines are not part of the ifblock.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@schreibubi
Copy link
Author

Any chance of getting this into the 22.07 release?

@AdSchellevis
Copy link
Member

We're still working on some other features as well with Unbound, not sure if we can add DoH and DoT in the same time scheme. It's still on our radar, just careful about adding potential future issues in legacy code while migrating to our new model at the same time.

@jumbi77
Copy link

jumbi77 commented Jul 9, 2022

@schreibubi @AdSchellevis Can i may ask the status of this PR? Get it upstreamed would be nice. Thanks for your contribution in any case!

@AdSchellevis
Copy link
Member

@jumbi77 situation hasn't changed, likely won't be merged in its current state, probably the functionality will be available at some point in time.

@schreibubi
Copy link
Author

@jumbi77 you can use the following commands to use my changes:
opnsense-patch 70c1cdc
configctl unbound restart

Added additional values to the unbound statistics page which allow to
monitor DoH and DoT queries.
@dwydler
Copy link

dwydler commented Mar 5, 2023

Is the OPNsense Patch from 10th July 2022 compatible with the newest version, 23.1?

@schreibubi
Copy link
Author

opnsense-patch 9e310c1 still works for 23.1

@fichtner
Copy link
Member

I'm closing this since unmergable after @swhite2 moved general unbound settings page to MVC.

@fichtner fichtner closed this May 12, 2023
@schreibubi
Copy link
Author

Updated PR against latest master #6558

@metronidazole
Copy link

Any chance this could be reopened? The OP has kept their repo up to date.

This would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Unbound for DoH
7 participants