Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifications so that guppy can be loaded using webpack #1

Merged
merged 2 commits into from Aug 18, 2020
Merged

Modifications so that guppy can be loaded using webpack #1

merged 2 commits into from Aug 18, 2020

Conversation

nishantwrp
Copy link

@nishantwrp nishantwrp commented Aug 17, 2020 •
edited

Added module.exports = Guppy in the build files. So, that we can do

const Guppy = require(guppy.min.js);

@seanlip
Copy link
Member

seanlip commented Aug 17, 2020

@nishantwrp please add a clearer description explaining what modifications are being done and why.

(In general, your PR descriptions could use more detail -- please bear this in mind for future PRs. Thanks!)

@seanlip seanlip assigned nishantwrp and unassigned seanlip Aug 17, 2020
@nishantwrp
Copy link
Author

@seanlip done!

@nishantwrp nishantwrp assigned seanlip and unassigned nishantwrp Aug 18, 2020
seanlip
seanlip approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@seanlip seanlip merged commit 7509f31 into oppia:master Aug 18, 2020
@nishantwrp nishantwrp deleted the webpack-config branch August 19, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanlip seanlip seanlip approved these changes

Assignees

@seanlip seanlip

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nishantwrp @seanlip