Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch images from offline storage or url and display in app module instead of dummy thumbnails #1152

Closed
rt4914 opened this issue May 28, 2020 · 0 comments · Fixed by #1554
Closed

Fetch images from offline storage or url and display in app module instead of dummy thumbnails #1152

rt4914 opened this issue May 28, 2020 · 0 comments · Fixed by #1554
Assignees
@rt4914
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.4 Release Block...

Comments

@rt4914
Copy link
Contributor

rt4914 commented May 28, 2020

Currently we are using LessonThumbnails to show images in various views. This should be replaced with images getting fetched from offline storage if they are available or from Online URL.

This project will be a part of entire TopicDownload Support.
@rt4914 rt4914 self-assigned this May 28, 2020
@rt4914 rt4914 added mini-project Priority: Essential This work item must be completed for its milestone. labels May 28, 2020
@BenHenning BenHenning added this to the Alpha milestone Jun 23, 2020
@rt4914 rt4914 mentioned this issue Aug 5, 2020
Merged
8 tasks
rt4914 added a commit that referenced this issue Aug 7, 2020
@rt4914 @BenHenning
Fix #1152: LessonThumbnailImageView (#1554)
c735bb3 
* LessonThumbnail Image View

* Draft approach for Lesson thumbnail

* Possible fix for Glide not liking custom models bound into views.

* Working implementation

* Added thumbnail support to Recently played screen, subtopics

* StoryTestHelper

* Profile Progress items

* Updated json files

* Reset progress test file

* Nit changes

* Nit changes

* Added thumbnail to new files

* Added todo

Co-authored-by: Rajat Talesra <talesra@google.com>
Co-authored-by: Ben Henning <bhenning@google.com>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
None yet
Milestone
0.4 Release Blockers (Alpha MR1)
Development

Successfully merging a pull request may close this issue.

Fix #1152: LessonThumbnailImageView oppia/oppia-android
2 participants
@rt4914 @BenHenning