Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3318: Add check to ensure all todos are addressed corresponding to the closed issue #3629

Merged
merged 267 commits into from
Aug 16, 2021
Merged

Fix #3318: Add check to ensure all todos are addressed corresponding to the closed issue #3629

merged 267 commits into from
Aug 16, 2021

Conversation

Sparsh1212
Copy link
Contributor

Explanation

Fixes #3318

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@Sparsh1212
Fix #3291: Add check for XML syntax correctness
51e64aa
@Sparsh1212
nit fixes
f440a33
@Sparsh1212
Merge branch 'regex-checks' into xml-syntax-check
255773d
@Sparsh1212
Introduce XML syntax check in static checks workflow
7b2a178
@Sparsh1212
Fix #3292: Add check for test files presence for prod files
14c5f6f
@Sparsh1212
Make nit suggestions
163310e
@Sparsh1212
Merge branch 'regex-checks' into xml-syntax-check
6131c1d
@Sparsh1212
Make nit suggestions
9cb5fc5
@Sparsh1212
Merge branch 'xml-syntax-check' into test-file-check
4120775
@Sparsh1212
Make nit suggestions
8c98cf2
@Sparsh1212
Fix #3300: Add check for accessibility labels for activities
7f1762c
@Sparsh1212
Add CI check for label presence for activities
5229ac9
@Sparsh1212
Add ScriptConstants file to exemptions test list
7e1d24a
@Sparsh1212
merge test-file-check
08cf6c3
@Sparsh1212
Test if: always()
b72e419
@Sparsh1212
Revert "Test if: always()"
d8472ab 
This reverts commit b72e419
@Sparsh1212
Add if: always()
fe42a64
@Sparsh1212
Merge branch 'xml-syntax-check' into test-file-check
e12f247
@Sparsh1212
Add if: always()
9fdb165
@Sparsh1212
Merge branch 'test-file-check' into accesibilty-label-check
7bf2726
@Sparsh1212
Add if: always()
6e3424b
@Sparsh1212
Apply review suggestions on PR
381853c
@Sparsh1212
Merge branch 'regex-checks' into xml-syntax-check
c59494f
@Sparsh1212
Make review suggestions from regex pattern checks
293ab92
@Sparsh1212
Merge branch 'xml-syntax-check' into test-file-check
f393e1e
@Sparsh1212
Implement review suggestions based on #3340
56d607e
@Sparsh1212
Refactor PR as per feedback recieved
d01a238
@Sparsh1212
Merge branch 'regex-checks' into xml-syntax-check
b7cb290
@Sparsh1212
Implement feedback suggestions
5a4ac03
@Sparsh1212
Merge branch 'xml-syntax-check' into test-file-check
f6b0715
@Sparsh1212 Sparsh1212 assigned BenHenning and unassigned Sparsh1212 Aug 13, 2021
BenHenning
BenHenning reviewed Aug 14, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, otherwise LGTM @Sparsh1212.

scripts/src/java/org/oppia/android/scripts/todo/TodoIssueResolvedCheck.kt Outdated Show resolved Hide resolved
@BenHenning BenHenning assigned Sparsh1212 and unassigned BenHenning Aug 14, 2021
@Sparsh1212 Sparsh1212 assigned BenHenning and unassigned Sparsh1212 Aug 14, 2021
@Sparsh1212
Copy link
Contributor Author

Just one comment, otherwise LGTM @Sparsh1212.

@BenHenning Followed up. PTAL.

@Sparsh1212 Sparsh1212 removed their assignment Aug 14, 2021
BenHenning
BenHenning reviewed Aug 16, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sparsh1212. This LGTM, please assign back once #3508 is merged & this PR is updated.

@BenHenning BenHenning assigned Sparsh1212 and unassigned BenHenning Aug 16, 2021
Base automatically changed from todo-check to develop August 16, 2021 18:26
@Sparsh1212 Sparsh1212 assigned BenHenning and unassigned Sparsh1212 Aug 16, 2021
BenHenning
BenHenning approved these changes Aug 16, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sparsh1212. LGTM!

@BenHenning BenHenning merged commit 2da95a5 into develop Aug 16, 2021
@BenHenning BenHenning deleted the closed-issue-check branch August 16, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenHenning BenHenning BenHenning approved these changes

@vinitamurthi vinitamurthi Awaiting requested review from vinitamurthi

@rt4914 rt4914 Awaiting requested review from rt4914

Assignees

@BenHenning BenHenning

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a workflow that verifies (through a Kotlin Script) that all the TODOs are addressed for a closed issue
3 participants
@Sparsh1212 @BenHenning @vinitamurthi