-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3318: Add check to ensure all todos are addressed corresponding to the closed issue #3629
Conversation
This reverts commit b72e419
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, otherwise LGTM @Sparsh1212.
scripts/src/java/org/oppia/android/scripts/todo/TodoIssueResolvedCheck.kt
Outdated
Show resolved
Hide resolved
@BenHenning Followed up. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Sparsh1212. This LGTM, please assign back once #3508 is merged & this PR is updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Sparsh1212. LGTM!
Explanation
Fixes #3318
Checklist