Fix #3290: Add support for generic regex pattern matching #3340

Sparsh1212 · 2021-06-18T06:51:18Z

Explanation

Fixes #3290: Add support for generic regex pattern matching

The script traverses different layers of the codebase to check for any prohibited file content and file naming patterns.
To run the script, use:

bazel run //scripts:regex_pattern_validation_check -- $(pwd)

For testing the script, automated tests have been added.
To execute the tests, use:

bazel test //scripts/src/javatests/org/oppia/android/scripts/regex:RegexPatternValidationCheckTest

Note: We are generating the test assets dynamically at the time of executing them. The test assets are automatically deleted, when the test finishes.

Screenshot of all new tests added passing locally:

Checklist

The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
The PR follows the style guide.
The PR does not contain any unnecessary auto-generated code from Android Studio.
The PR is made from a branch that's not called "develop".
The PR is made from a branch that is up-to-date with "develop".
The PR's branch is based on "develop" and not on any other branch.
The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

anandwana001

Thanks, @Sparsh1212
Just make sure my earlier review is last closed or is updated here in this PR.

Regarding the test file, I am wondering if we can use assertThat and pass the expected and original value to compare and see if the test pass or not rather than script pass.

scripts/src/java/org/oppia/android/scripts/RegexPatternValidationCheck.kt

anandwana001 · 2021-06-20T16:50:01Z

scripts/src/java/org/oppia/android/scripts/RegexPatternValidationCheck.kt

+      }
+    }
+
+    fun getFilenameChecks(): List<FilenameCheck> {


Nit on naming: get usually refers to methods that are trivially retrieving data. Instead, consider: retrieveFilenameChecks since that more explicitly implies work is being done to fetch the data being returned & to not be confused with a simple getter.

@BenHenning
Thanks, done.

scripts/src/java/org/oppia/android/scripts/RegexPatternValidationCheck.kt

scripts/src/test/org/oppia/android/scripts/RegexPatternValidationCheckTest.kt

BenHenning

Thanks @Sparsh1212. Just a few nits, but otherwise the PR LGTM. Will approve after #3416 is merged & CI checks are verified as passing.

Please assign back once the comments below are addressed, #3416 is merged, this is updated with develop, and CI checks are passing.

scripts/BUILD.bazel

scripts/src/java/org/oppia/android/scripts/proto/BUILD.bazel

) * Add new tests for .bzl files. The new test is meant to determine whether changes to .bzl files can also trigger a hang in CI in the same way that WORKSPACE files do. * Add missing argument to invocation example. * Add debug lines for investigation. * Attempt new test for investigation. This test introduces bzl file indirection closer to #3340 to see if that's the scenario that causes CI to hang. * Move fix from test branch. This change is meant to reduce the filesystem & processing cost for computing tests affected by BUILD/bzl file changes to reduce the chance of it hanging in CI environments. This also disables a test that's known to hang in CI environments to see if it fixes the issue.

BenHenning

Thanks @Sparsh1212. LGTM since relevant CI are passing & all comments are resolved. Please merge after CI is fully green.

BenHenning · 2021-07-08T21:13:44Z

Merging since all CI checks are now passing.

* Fix #3290: Add support for generic regex pattern matching * Apply review suggestions for proto location * Delete main directory * Implment script logic and tests * CI setup part 1 * syntax fix in yaml file * import nits in dummy file * Use regex patterns from script in script test * Make PR suggestions into effect * Make PR suggestions into effect * Make PR suggestions into effect * Improve naming of script_assets variables * Make PR suggestions into effect * Make PR suggestions * Make PR suggestions * Revamp testing approach * Fix #3291: Add check for XML syntax correctness * nit fixes * Introduce XML syntax check in static checks workflow * Fix #3292: Add check for test files presence for prod files * Make nit suggestions * Make nit suggestions * Make nit suggestions * Add ScriptConstants file to exemptions test list * Add if: always() * Add if: always() * Apply review suggestions on PR * Make review suggestions from regex pattern checks * Implement review suggestions based on #3340 * Refactor PR as per feedback recieved * Implement feedback suggestions * Implement review suggestions * Implement review suggestions * Implement review suggestions * Implement review suggestions * nits * Nit fixes * Nit fixes * Nit fixes * nit fix * nit fix * Review suggestions part 1 * Implement review suggestions part 2 * nit fixes * update static_checks * add test to repository file * nit fix * nit fix * nit fix * Do review suggestions * Implement review suggestions * Implement review suggestions * nit fix * Implement review suggestions * Add Ben as a codeowner for the ScriptExemptions file * bazel files nit fix * Introduce a library for the regex assets * Make directory structure same as that of #3374 * Make directory structure similar to #3374 * add new files to test file script exemptions and nit fixes * diable ktlint max-line-length * disable ktlint-max-line * disable ktlint max-length * remove testonly attribute from tests * add new files to script exemptions * nit fix * nit fix * Apply review suggestions * ktlint fix * nit fix * Apply nit fixes * Apply nit fixes * Remove script constants * nit fix * add todo * add todo * nit fixes * add test * add testOnly * nit fixes * nit fix * nit fixes * nit fixes * nit fixes * nit fixes * fix textproto file * add exemptions to textproto * sort failures lexicographically * add new files to exemption list

* Fix #3290: Add support for generic regex pattern matching * Apply review suggestions for proto location * Delete main directory * Implment script logic and tests * CI setup part 1 * syntax fix in yaml file * import nits in dummy file * Use regex patterns from script in script test * Make PR suggestions into effect * Make PR suggestions into effect * Make PR suggestions into effect * Improve naming of script_assets variables * Make PR suggestions into effect * Make PR suggestions * Make PR suggestions * Revamp testing approach * Fix #3291: Add check for XML syntax correctness * nit fixes * Introduce XML syntax check in static checks workflow * Fix #3292: Add check for test files presence for prod files * Make nit suggestions * Make nit suggestions * Make nit suggestions * Fix #3300: Add check for accessibility labels for activities * Add CI check for label presence for activities * Add ScriptConstants file to exemptions test list * Test if: always() * Revert "Test if: always()" This reverts commit b72e419 * Add if: always() * Add if: always() * Add if: always() * Apply review suggestions on PR * Make review suggestions from regex pattern checks * Implement review suggestions based on #3340 * Refactor PR as per feedback recieved * Implement feedback suggestions * Implement review suggestions * Implement review suggestions * Implement review suggestions * Implement review suggestions * nits * Nit fixes * Nit fixes * Nit fixes * Implement feedback suggestions as per #3340 * nit fix * nit fix * nit fix * nit fix * Review suggestions part 1 * Implement review suggestions part 2 * nit fixes * update static_checks * add test to repository file * nit fix * nit fix * nit fix * Do review suggestions * Implement review suggestions * Implement review suggestions * nit fix * Implement review suggestions * Add Ben as a codeowner for the ScriptExemptions file * bazel files nit fix * Introduce a library for the regex assets * Make directory structure same as that of #3374 * Make directory structure similar to #3374 * add new files to test file script exemptions and nit fixes * diable ktlint max-line-length * disable ktlint-max-line * disable ktlint max-length * remove testonly attribute from tests * add new files to script exemptions * nit fix * nit fix * nit fix * Apply review suggestions * ktlint fix * nit fix * Apply nit fixes * Apply nit fixes * Remove script constants * nit fix * add todo * add todo * nit fixes * add test * add testOnly * nit fixes * nit fix * nit fixes * nit fixes * nit fixes * nit fixes * fix textproto file * add exemptions to textproto * sort failures lexicographically * add new files to exemption list * nit fixes * nit fixes * add kdocs * nit fix * nit fix * Trigger CI failure exclusively * Revert CI check failure * nit fix * nit fix * nit fixes * nit fixes * nit fixes * Add redundant exemptions check * rectify static_checks * Remove duplicate proto libraries * nit fixes * add activity to exemption * nit fixes * nit fixes * nit fixes * update branch

…3499) * Fix #3290: Add support for generic regex pattern matching * Apply review suggestions for proto location * Delete main directory * Implment script logic and tests * CI setup part 1 * syntax fix in yaml file * import nits in dummy file * Use regex patterns from script in script test * Make PR suggestions into effect * Make PR suggestions into effect * Make PR suggestions into effect * Improve naming of script_assets variables * Make PR suggestions into effect * Make PR suggestions * Make PR suggestions * Revamp testing approach * Fix #3291: Add check for XML syntax correctness * nit fixes * Introduce XML syntax check in static checks workflow * Fix #3292: Add check for test files presence for prod files * Make nit suggestions * Make nit suggestions * Make nit suggestions * Fix #3300: Add check for accessibility labels for activities * Add CI check for label presence for activities * Add ScriptConstants file to exemptions test list * Test if: always() * Revert "Test if: always()" This reverts commit b72e419 * Add if: always() * Add if: always() * Add if: always() * Apply review suggestions on PR * Make review suggestions from regex pattern checks * Implement review suggestions based on #3340 * Refactor PR as per feedback recieved * Implement feedback suggestions * Implement review suggestions * Implement review suggestions * Implement review suggestions * Implement review suggestions * nits * Nit fixes * Nit fixes * Nit fixes * Implement feedback suggestions as per #3340 * nit fix * nit fix * nit fix * nit fix * Review suggestions part 1 * Implement review suggestions part 2 * nit fixes * update static_checks * add test to repository file * nit fix * nit fix * nit fix * Do review suggestions * Implement review suggestions * Implement review suggestions * nit fix * Implement review suggestions * Add Ben as a codeowner for the ScriptExemptions file * bazel files nit fix * Introduce a library for the regex assets * Make directory structure same as that of #3374 * Make directory structure similar to #3374 * add new files to test file script exemptions and nit fixes * diable ktlint max-line-length * disable ktlint-max-line * disable ktlint max-length * remove testonly attribute from tests * add new files to script exemptions * nit fix * nit fix * nit fix * Apply review suggestions * ktlint fix * nit fix * Apply nit fixes * Apply nit fixes * Remove script constants * nit fix * add todo * add todo * nit fixes * add test * add testOnly * nit fixes * nit fix * nit fixes * nit fixes * nit fixes * nit fixes * fix textproto file * add exemptions to textproto * sort failures lexicographically * add new files to exemption list * nit fixes * nit fixes * add kdocs * nit fix * nit fix * Trigger CI failure exclusively * Revert CI check failure * Fix #3340: Create a script to ensure KDoc presence * Add initial tests * Add more tests and add documentation * nit fix * nit fix * nit fix * nit fix * Add more files to kdoc exemptions * nit fixes * nit fixes * nit fixes * Add redundant exemptions check * rectify static_checks * Remove duplicate proto libraries * nit fixes * nit fixes and add redundant exemptions check to script * nit fixes * add activity to exemption * nit fixes * nit fixes * nit fixes * nit fixes * nit fixes * update branch * nit fixes

…nd correspond to an open issue on Github (#3508) * Fix #3290: Add support for generic regex pattern matching * Apply review suggestions for proto location * Delete main directory * Implment script logic and tests * CI setup part 1 * syntax fix in yaml file * import nits in dummy file * Use regex patterns from script in script test * Make PR suggestions into effect * Make PR suggestions into effect * Make PR suggestions into effect * Improve naming of script_assets variables * Make PR suggestions into effect * Make PR suggestions * Make PR suggestions * Revamp testing approach * Fix #3291: Add check for XML syntax correctness * nit fixes * Introduce XML syntax check in static checks workflow * Fix #3292: Add check for test files presence for prod files * Make nit suggestions * Make nit suggestions * Make nit suggestions * Fix #3300: Add check for accessibility labels for activities * Add CI check for label presence for activities * Add ScriptConstants file to exemptions test list * Test if: always() * Revert "Test if: always()" This reverts commit b72e419 * Add if: always() * Add if: always() * Add if: always() * Apply review suggestions on PR * Make review suggestions from regex pattern checks * Implement review suggestions based on #3340 * Refactor PR as per feedback recieved * Implement feedback suggestions * Implement review suggestions * Implement review suggestions * Implement review suggestions * Implement review suggestions * nits * Nit fixes * Nit fixes * Nit fixes * Implement feedback suggestions as per #3340 * nit fix * nit fix * nit fix * nit fix * Review suggestions part 1 * Implement review suggestions part 2 * nit fixes * update static_checks * add test to repository file * nit fix * nit fix * nit fix * Do review suggestions * Implement review suggestions * Implement review suggestions * nit fix * Implement review suggestions * Add Ben as a codeowner for the ScriptExemptions file * bazel files nit fix * Introduce a library for the regex assets * Make directory structure same as that of #3374 * Make directory structure similar to #3374 * add new files to test file script exemptions and nit fixes * diable ktlint max-line-length * disable ktlint-max-line * disable ktlint max-length * remove testonly attribute from tests * add new files to script exemptions * nit fix * nit fix * nit fix * Apply review suggestions * ktlint fix * nit fix * Apply nit fixes * Apply nit fixes * Remove script constants * nit fix * add todo * add todo * nit fixes * add test * add testOnly * nit fixes * nit fix * nit fixes * nit fixes * nit fixes * nit fixes * fix textproto file * add exemptions to textproto * sort failures lexicographically * add new files to exemption list * nit fixes * nit fixes * add kdocs * nit fix * nit fix * Trigger CI failure exclusively * Revert CI check failure * Fix #3340: Create a script to ensure KDoc presence * Add initial tests * Add more tests and add documentation * nit fix * nit fix * nit fix * nit fix * Add more files to kdoc exemptions * Implementation part 1 * add exemption proto for todos * nit fixes * delete open issues * nit fixes * nit fixes * Add redundant exemptions check * rectify static_checks * Remove duplicate proto libraries * nit fixes * nit fixes and add redundant exemptions check to script * nit fixes * add activity to exemption * nit fixes * nit fixes * nit fixes * nit fixes * revamption part 1 * nit fixes * update branch * Revamped approach * nit fixes * add kdocs * delete open_issues.json * Fix #3317: Update old todos * nit fixes * Remove resolved todos * Repurpose todos stage 1 * Repurpose todos stage 2 * updating todos part 3 * update more todos * add network module * update todo no. 322 * Remove unused imports * Revert "Remove unused imports" This reverts commit 65ee6e9. * Revert "update todo no. 322" This reverts commit c150cdc. * Repurpose no. 322 * nit fixes * replace issue number for backend model todo * link new filed issue * nit fixes * add exemptions * nit fixes * nit fixes * nit fixes * add remaining tests for all cases * nit fixes * nit fixes Co-authored-by: Sparsh Agrawal <sparsh@Sparshs-MacBook-Air.local>

…to the closed issue (#3629) * Fix #3291: Add check for XML syntax correctness * nit fixes * Introduce XML syntax check in static checks workflow * Fix #3292: Add check for test files presence for prod files * Make nit suggestions * Make nit suggestions * Make nit suggestions * Fix #3300: Add check for accessibility labels for activities * Add CI check for label presence for activities * Add ScriptConstants file to exemptions test list * Test if: always() * Revert "Test if: always()" This reverts commit b72e419 * Add if: always() * Add if: always() * Add if: always() * Apply review suggestions on PR * Make review suggestions from regex pattern checks * Implement review suggestions based on #3340 * Refactor PR as per feedback recieved * Implement feedback suggestions * Implement review suggestions * Implement review suggestions * Implement review suggestions * Implement review suggestions * nits * Nit fixes * Nit fixes * Nit fixes * Implement feedback suggestions as per #3340 * nit fix * nit fix * nit fix * nit fix * Review suggestions part 1 * Implement review suggestions part 2 * nit fixes * update static_checks * add test to repository file * nit fix * nit fix * nit fix * Do review suggestions * Implement review suggestions * Implement review suggestions * nit fix * Implement review suggestions * Add Ben as a codeowner for the ScriptExemptions file * bazel files nit fix * Introduce a library for the regex assets * Make directory structure same as that of #3374 * Make directory structure similar to #3374 * add new files to test file script exemptions and nit fixes * diable ktlint max-line-length * disable ktlint-max-line * disable ktlint max-length * remove testonly attribute from tests * add new files to script exemptions * nit fix * nit fix * nit fix * Apply review suggestions * ktlint fix * nit fix * Apply nit fixes * Apply nit fixes * Remove script constants * nit fix * add todo * add todo * nit fixes * add test * add testOnly * nit fixes * nit fix * nit fixes * nit fixes * nit fixes * nit fixes * fix textproto file * add exemptions to textproto * sort failures lexicographically * add new files to exemption list * nit fixes * nit fixes * add kdocs * nit fix * nit fix * Trigger CI failure exclusively * Revert CI check failure * Fix #3340: Create a script to ensure KDoc presence * Add initial tests * Add more tests and add documentation * nit fix * nit fix * nit fix * nit fix * Add more files to kdoc exemptions * Implementation part 1 * add exemption proto for todos * nit fixes * delete open issues * nit fixes * nit fixes * Add redundant exemptions check * rectify static_checks * Remove duplicate proto libraries * nit fixes * nit fixes and add redundant exemptions check to script * nit fixes * add activity to exemption * nit fixes * nit fixes * nit fixes * nit fixes * revamption part 1 * nit fixes * update branch * Revamped approach * nit fixes * add kdocs * delete open_issues.json * Fix #3317: Update old todos * nit fixes * Remove resolved todos * Repurpose todos stage 1 * Repurpose todos stage 2 * Fix #3318: Add check to ensure all todos of closed issue are resolved * nit fixes * updating todos part 3 * add tests * update more todos * add network module * update todo no. 322 * correct if condition in workflow * Remove unused imports * Add duplicate comment check condition * nit fixes * Correct exit code * Revert "Remove unused imports" This reverts commit 65ee6e9. * Revert "update todo no. 322" This reverts commit c150cdc. * Repurpose no. 322 * nit fixes * replace issue number for backend model todo * add tests * link new filed issue * nit fixes * add exemptions * nit fixes * nit fixes * nit fixes * nit fixes * nit fixes * add remaining tests for all cases * nit fixes * nit fixes * nit fixes Co-authored-by: Sparsh Agrawal <sparsh@Sparshs-MacBook-Air.local>

* Make nit suggestions * Make nit suggestions * Fix #3300: Add check for accessibility labels for activities * Add CI check for label presence for activities * Add ScriptConstants file to exemptions test list * Test if: always() * Revert "Test if: always()" This reverts commit b72e419 * Add if: always() * Add if: always() * Add if: always() * Apply review suggestions on PR * Make review suggestions from regex pattern checks * Implement review suggestions based on #3340 * Refactor PR as per feedback recieved * Implement feedback suggestions * Implement review suggestions * Implement review suggestions * Implement review suggestions * Implement review suggestions * nits * Nit fixes * Nit fixes * Nit fixes * Implement feedback suggestions as per #3340 * nit fix * nit fix * nit fix * nit fix * Review suggestions part 1 * Implement review suggestions part 2 * nit fixes * update static_checks * add test to repository file * nit fix * nit fix * nit fix * Do review suggestions * Implement review suggestions * Implement review suggestions * nit fix * Implement review suggestions * Add Ben as a codeowner for the ScriptExemptions file * bazel files nit fix * Introduce a library for the regex assets * Make directory structure same as that of #3374 * Make directory structure similar to #3374 * add new files to test file script exemptions and nit fixes * diable ktlint max-line-length * disable ktlint-max-line * disable ktlint max-length * remove testonly attribute from tests * add new files to script exemptions * nit fix * nit fix * nit fix * Apply review suggestions * ktlint fix * nit fix * Apply nit fixes * Apply nit fixes * Remove script constants * nit fix * add todo * add todo * nit fixes * add test * add testOnly * nit fixes * nit fix * nit fixes * nit fixes * nit fixes * nit fixes * fix textproto file * add exemptions to textproto * sort failures lexicographically * add new files to exemption list * nit fixes * nit fixes * add kdocs * nit fix * nit fix * Trigger CI failure exclusively * Revert CI check failure * Fix #3340: Create a script to ensure KDoc presence * Add initial tests * Add more tests and add documentation * nit fix * nit fix * nit fix * nit fix * Add more files to kdoc exemptions * Implementation part 1 * add exemption proto for todos * nit fixes * delete open issues * nit fixes * nit fixes * Add redundant exemptions check * rectify static_checks * Remove duplicate proto libraries * nit fixes * nit fixes and add redundant exemptions check to script * nit fixes * add activity to exemption * nit fixes * nit fixes * nit fixes * nit fixes * revamption part 1 * nit fixes * update branch * Revamped approach * nit fixes * add kdocs * delete open_issues.json * Fix #3317: Update old todos * nit fixes * Remove resolved todos * Repurpose todos stage 1 * Repurpose todos stage 2 * Fix #3318: Add check to ensure all todos of closed issue are resolved * nit fixes * updating todos part 3 * add tests * update more todos * add network module * update todo no. 322 * correct if condition in workflow * Remove unused imports * Add duplicate comment check condition * nit fixes * Correct exit code * Revert "Remove unused imports" This reverts commit 65ee6e9. * Revert "update todo no. 322" This reverts commit c150cdc. * Repurpose no. 322 * nit fixes * replace issue number for backend model todo * add tests * link new filed issue * nit fixes * add exemptions * nit fixes * nit fixes * nit fixes * nit fixes * nit fixes * add remaining tests for all cases * point error messages to wiki * nit fixes * nit fixes * nit fixes * nit fixes * log check medication only once * reference exact urls * correct flaky test Co-authored-by: Sparsh Agrawal <sparsh@Sparshs-MacBook-Air.local>

Sparsh1212 added 15 commits June 14, 2021 20:43

Fix #3290: Add support for generic regex pattern matching

225a4fc

Apply review suggestions for proto location

638895f

Delete main directory

e3fd706

Implment script logic and tests

b25e776

CI setup part 1

d44e015

syntax fix in yaml file

de1d38f

import nits in dummy file

173fe53

Use regex patterns from script in script test

618e380

Make PR suggestions into effect

e3830ac

Make PR suggestions into effect

bb93c0a

Make PR suggestions into effect

f7342c1

Improve naming of script_assets variables

51e593b

Make PR suggestions into effect

0d17657

Make PR suggestions

16bb041

Make PR suggestions

325f28c

Sparsh1212 requested review from anandwana001, fsharpasharp and vinitamurthi as code owners June 18, 2021 06:51

Sparsh1212 assigned BenHenning, vinitamurthi, anandwana001 and fsharpasharp and unassigned vinitamurthi Jun 18, 2021

Sparsh1212 mentioned this pull request Jun 18, 2021

Fix #3290: Add support for generic regex pattern matching #3328

Closed

8 tasks

Sparsh1212 added 3 commits June 18, 2021 14:53

Revamp testing approach

a3f8ea6

Merge branch 'develop' into regex-checks

b1970eb

nit fixes

f440a33

This was referenced Jun 18, 2021

Fix #3291: Add check for XML syntax validation #3341

Merged

Fix #3292: Add check for test files presence for prod files #3343

Merged

anandwana001 suggested changes Jun 20, 2021

View reviewed changes

Sparsh1212 mentioned this pull request Jul 7, 2021

Refactor textproto assets to subpackage level #3428

Open

add todo

31c1df5

Sparsh1212 assigned BenHenning and unassigned Sparsh1212 Jul 7, 2021

Sparsh1212 requested a review from BenHenning July 7, 2021 15:44

prayutsu mentioned this pull request Jul 7, 2021

Fix #3285: Create Kotlin script to compile list of maven dependencies and license links #3434

Merged

8 tasks

Merge branch 'develop' into regex-checks

5ed9d9a

BenHenning reviewed Jul 8, 2021

View reviewed changes

scripts/BUILD.bazel Show resolved Hide resolved

scripts/BUILD.bazel Show resolved Hide resolved

scripts/src/java/org/oppia/android/scripts/proto/BUILD.bazel Outdated Show resolved Hide resolved

BenHenning assigned Sparsh1212 and unassigned BenHenning Jul 8, 2021

prayutsu mentioned this pull request Jul 8, 2021

Fix #3287: Introduce Kotlin script to extract license texts #3444

Closed

8 tasks

Sparsh1212 added 3 commits July 8, 2021 16:16

nit fixes

c30158c

Merge branch 'develop' into regex-checks

d57ef42

add testOnly

91e108a

BenHenning approved these changes Jul 8, 2021

View reviewed changes

Sparsh1212 assigned BenHenning and unassigned Sparsh1212 Jul 8, 2021

BenHenning merged commit 72bd749 into develop Jul 8, 2021

BenHenning deleted the regex-checks branch July 8, 2021 21:13

BenHenning restored the regex-checks branch July 8, 2021 21:22

BenHenning deleted the regex-checks branch July 8, 2021 22:03

Sparsh1212 added a commit that referenced this pull request Jul 17, 2021

Fix #3340: Create a script to ensure KDoc presence

1fdf50e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #3290: Add support for generic regex pattern matching #3340

Fix #3290: Add support for generic regex pattern matching #3340

Sparsh1212 commented Jun 18, 2021 •

edited

Loading

anandwana001 left a comment

anandwana001 Jun 20, 2021

Sparsh1212 Jun 20, 2021

BenHenning Jun 22, 2021

Sparsh1212 Jun 22, 2021 •

edited

Loading

BenHenning left a comment •

edited

Loading

BenHenning left a comment

BenHenning commented Jul 8, 2021

Fix #3290: Add support for generic regex pattern matching #3340

Fix #3290: Add support for generic regex pattern matching #3340

Conversation

Sparsh1212 commented Jun 18, 2021 • edited Loading

Explanation

Checklist

anandwana001 left a comment

Choose a reason for hiding this comment

anandwana001 Jun 20, 2021

Choose a reason for hiding this comment

Sparsh1212 Jun 20, 2021

Choose a reason for hiding this comment

BenHenning Jun 22, 2021

Choose a reason for hiding this comment

Sparsh1212 Jun 22, 2021 • edited Loading

Choose a reason for hiding this comment

BenHenning left a comment • edited Loading

Choose a reason for hiding this comment

BenHenning left a comment

Choose a reason for hiding this comment

BenHenning commented Jul 8, 2021

Sparsh1212 commented Jun 18, 2021 •

edited

Loading

Sparsh1212 Jun 22, 2021 •

edited

Loading

BenHenning left a comment •

edited

Loading