Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a Kotlin script to ensure that activities are defined with accessibility labels #3300

Closed
Sparsh1212 opened this issue Jun 11, 2021 · 0 comments · Fixed by #3352
Closed

Create a Kotlin script to ensure that activities are defined with accessibility labels #3300

Sparsh1212 opened this issue Jun 11, 2021 · 0 comments · Fixed by #3352
Assignees
@Sparsh1212
Labels
Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Sparsh1212
Copy link
Contributor

Activities must be defined with an accessibility label so that it helps the A11y users while transitioning to a new activity. Create a script which ensures the same.

Target PR date: 2021-08-05
Target completion date: 2021-08-08
@Sparsh1212 Sparsh1212 self-assigned this Jun 11, 2021
@Sparsh1212 Sparsh1212 added Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. labels Jun 11, 2021
@Sparsh1212 Sparsh1212 added this to the GSoC 2021.2: Milestone 2 milestone Jun 11, 2021
Sparsh1212 added a commit that referenced this issue Jun 21, 2021
@Sparsh1212
Fix #3300: Add check for accessibility labels for activities
7f1762c
@Sparsh1212 Sparsh1212 mentioned this issue Jun 21, 2021
Merged
8 tasks
@Sparsh1212 Sparsh1212 changed the title Create a Koltin script to ensure that activities are defined with accessibility labels Create a Kotlin script to ensure that activities are defined with accessibility labels Jun 21, 2021
BenHenning pushed a commit that referenced this issue Jul 29, 2021
@Sparsh1212
Fix #3300: Add check for accessibility label for activities (#3352)
6610306 
* Fix #3290: Add support for generic regex pattern matching

* Apply review suggestions for proto location

* Delete main directory

* Implment script logic and tests

* CI setup part 1

* syntax fix in yaml file

* import nits in dummy file

* Use regex patterns from script in script test

* Make PR suggestions into effect

* Make PR suggestions into effect

* Make PR suggestions into effect

* Improve naming of script_assets variables

* Make PR suggestions into effect

* Make PR suggestions

* Make PR suggestions

* Revamp testing approach

* Fix #3291: Add check for XML syntax correctness

* nit fixes

* Introduce XML syntax check in static checks workflow

* Fix #3292: Add check for test files presence for prod files

* Make nit suggestions

* Make nit suggestions

* Make nit suggestions

* Fix #3300: Add check for accessibility labels for activities

* Add CI check for label presence for activities

* Add ScriptConstants file to exemptions test list

* Test if: always()

* Revert "Test if: always()"

This reverts commit b72e419

* Add if: always()

* Add if: always()

* Add if: always()

* Apply review suggestions on PR

* Make review suggestions from regex pattern checks

* Implement review suggestions based on #3340

* Refactor PR as per feedback recieved

* Implement feedback suggestions

* Implement review suggestions

* Implement review suggestions

* Implement review suggestions

* Implement review suggestions

* nits

* Nit fixes

* Nit fixes

* Nit fixes

* Implement feedback suggestions as per #3340

* nit fix

* nit fix

* nit fix

* nit fix

* Review suggestions part 1

* Implement review suggestions part 2

* nit fixes

* update static_checks

* add test to repository file

* nit fix

* nit fix

* nit fix

* Do review suggestions

* Implement review suggestions

* Implement review suggestions

* nit fix

* Implement review suggestions

* Add Ben as a codeowner for the ScriptExemptions file

* bazel files nit fix

* Introduce a library for the regex assets

* Make directory structure same as that of #3374

* Make directory structure similar to #3374

* add new files to test file script exemptions and nit fixes

* diable ktlint max-line-length

* disable ktlint-max-line

* disable ktlint max-length

* remove testonly attribute from tests

* add new files to script exemptions

* nit fix

* nit fix

* nit fix

* Apply review suggestions

* ktlint fix

* nit fix

* Apply nit fixes

* Apply nit fixes

* Remove script constants

* nit fix

* add todo

* add todo

* nit fixes

* add test

* add testOnly

* nit fixes

* nit fix

* nit fixes

* nit fixes

* nit fixes

* nit fixes

* fix textproto file

* add exemptions to textproto

* sort failures lexicographically

* add new files to exemption list

* nit fixes

* nit fixes

* add kdocs

* nit fix

* nit fix

* Trigger CI failure exclusively

* Revert CI check failure

* nit fix

* nit fix

* nit fixes

* nit fixes

* nit fixes

* Add redundant exemptions check

* rectify static_checks

* Remove duplicate proto libraries

* nit fixes

* add activity to exemption

* nit fixes

* nit fixes

* nit fixes

* update branch
anandwana001 pushed a commit that referenced this issue Jul 30, 2021
@Sparsh1212
Fix #3304: Add check to ensure KDoc presence for non-private members (#…
5c57dd8 
…3499)

* Fix #3290: Add support for generic regex pattern matching

* Apply review suggestions for proto location

* Delete main directory

* Implment script logic and tests

* CI setup part 1

* syntax fix in yaml file

* import nits in dummy file

* Use regex patterns from script in script test

* Make PR suggestions into effect

* Make PR suggestions into effect

* Make PR suggestions into effect

* Improve naming of script_assets variables

* Make PR suggestions into effect

* Make PR suggestions

* Make PR suggestions

* Revamp testing approach

* Fix #3291: Add check for XML syntax correctness

* nit fixes

* Introduce XML syntax check in static checks workflow

* Fix #3292: Add check for test files presence for prod files

* Make nit suggestions

* Make nit suggestions

* Make nit suggestions

* Fix #3300: Add check for accessibility labels for activities

* Add CI check for label presence for activities

* Add ScriptConstants file to exemptions test list

* Test if: always()

* Revert "Test if: always()"

This reverts commit b72e419

* Add if: always()

* Add if: always()

* Add if: always()

* Apply review suggestions on PR

* Make review suggestions from regex pattern checks

* Implement review suggestions based on #3340

* Refactor PR as per feedback recieved

* Implement feedback suggestions

* Implement review suggestions

* Implement review suggestions

* Implement review suggestions

* Implement review suggestions

* nits

* Nit fixes

* Nit fixes

* Nit fixes

* Implement feedback suggestions as per #3340

* nit fix

* nit fix

* nit fix

* nit fix

* Review suggestions part 1

* Implement review suggestions part 2

* nit fixes

* update static_checks

* add test to repository file

* nit fix

* nit fix

* nit fix

* Do review suggestions

* Implement review suggestions

* Implement review suggestions

* nit fix

* Implement review suggestions

* Add Ben as a codeowner for the ScriptExemptions file

* bazel files nit fix

* Introduce a library for the regex assets

* Make directory structure same as that of #3374

* Make directory structure similar to #3374

* add new files to test file script exemptions and nit fixes

* diable ktlint max-line-length

* disable ktlint-max-line

* disable ktlint max-length

* remove testonly attribute from tests

* add new files to script exemptions

* nit fix

* nit fix

* nit fix

* Apply review suggestions

* ktlint fix

* nit fix

* Apply nit fixes

* Apply nit fixes

* Remove script constants

* nit fix

* add todo

* add todo

* nit fixes

* add test

* add testOnly

* nit fixes

* nit fix

* nit fixes

* nit fixes

* nit fixes

* nit fixes

* fix textproto file

* add exemptions to textproto

* sort failures lexicographically

* add new files to exemption list

* nit fixes

* nit fixes

* add kdocs

* nit fix

* nit fix

* Trigger CI failure exclusively

* Revert CI check failure

* Fix #3340: Create a script to ensure KDoc presence

* Add initial tests

* Add more tests and add documentation

* nit fix

* nit fix

* nit fix

* nit fix

* Add more files to kdoc exemptions

* nit fixes

* nit fixes

* nit fixes

* Add redundant exemptions check

* rectify static_checks

* Remove duplicate proto libraries

* nit fixes

* nit fixes and add redundant exemptions check to script

* nit fixes

* add activity to exemption

* nit fixes

* nit fixes

* nit fixes

* nit fixes

* nit fixes

* update branch

* nit fixes
BenHenning pushed a commit that referenced this issue Aug 16, 2021
@Sparsh1212
Fixes: #3296: Add check to ensure all TODOs are correctly formatted a…
aff226b 
…nd correspond to an open issue on Github (#3508)

* Fix #3290: Add support for generic regex pattern matching

* Apply review suggestions for proto location

* Delete main directory

* Implment script logic and tests

* CI setup part 1

* syntax fix in yaml file

* import nits in dummy file

* Use regex patterns from script in script test

* Make PR suggestions into effect

* Make PR suggestions into effect

* Make PR suggestions into effect

* Improve naming of script_assets variables

* Make PR suggestions into effect

* Make PR suggestions

* Make PR suggestions

* Revamp testing approach

* Fix #3291: Add check for XML syntax correctness

* nit fixes

* Introduce XML syntax check in static checks workflow

* Fix #3292: Add check for test files presence for prod files

* Make nit suggestions

* Make nit suggestions

* Make nit suggestions

* Fix #3300: Add check for accessibility labels for activities

* Add CI check for label presence for activities

* Add ScriptConstants file to exemptions test list

* Test if: always()

* Revert "Test if: always()"

This reverts commit b72e419

* Add if: always()

* Add if: always()

* Add if: always()

* Apply review suggestions on PR

* Make review suggestions from regex pattern checks

* Implement review suggestions based on #3340

* Refactor PR as per feedback recieved

* Implement feedback suggestions

* Implement review suggestions

* Implement review suggestions

* Implement review suggestions

* Implement review suggestions

* nits

* Nit fixes

* Nit fixes

* Nit fixes

* Implement feedback suggestions as per #3340

* nit fix

* nit fix

* nit fix

* nit fix

* Review suggestions part 1

* Implement review suggestions part 2

* nit fixes

* update static_checks

* add test to repository file

* nit fix

* nit fix

* nit fix

* Do review suggestions

* Implement review suggestions

* Implement review suggestions

* nit fix

* Implement review suggestions

* Add Ben as a codeowner for the ScriptExemptions file

* bazel files nit fix

* Introduce a library for the regex assets

* Make directory structure same as that of #3374

* Make directory structure similar to #3374

* add new files to test file script exemptions and nit fixes

* diable ktlint max-line-length

* disable ktlint-max-line

* disable ktlint max-length

* remove testonly attribute from tests

* add new files to script exemptions

* nit fix

* nit fix

* nit fix

* Apply review suggestions

* ktlint fix

* nit fix

* Apply nit fixes

* Apply nit fixes

* Remove script constants

* nit fix

* add todo

* add todo

* nit fixes

* add test

* add testOnly

* nit fixes

* nit fix

* nit fixes

* nit fixes

* nit fixes

* nit fixes

* fix textproto file

* add exemptions to textproto

* sort failures lexicographically

* add new files to exemption list

* nit fixes

* nit fixes

* add kdocs

* nit fix

* nit fix

* Trigger CI failure exclusively

* Revert CI check failure

* Fix #3340: Create a script to ensure KDoc presence

* Add initial tests

* Add more tests and add documentation

* nit fix

* nit fix

* nit fix

* nit fix

* Add more files to kdoc exemptions

* Implementation part 1

* add exemption proto for todos

* nit fixes

* delete open issues

* nit fixes

* nit fixes

* Add redundant exemptions check

* rectify static_checks

* Remove duplicate proto libraries

* nit fixes

* nit fixes and add redundant exemptions check to script

* nit fixes

* add activity to exemption

* nit fixes

* nit fixes

* nit fixes

* nit fixes

* revamption part 1

* nit fixes

* update branch

* Revamped approach

* nit fixes

* add kdocs

* delete open_issues.json

* Fix #3317: Update old todos

* nit fixes

* Remove resolved todos

* Repurpose todos stage 1

* Repurpose todos stage 2

* updating todos part 3

* update more todos

* add network module

* update todo no. 322

* Remove unused imports

* Revert "Remove unused imports"

This reverts commit 65ee6e9.

* Revert "update todo no. 322"

This reverts commit c150cdc.

* Repurpose no. 322

* nit fixes

* replace issue number for backend model todo

* link new filed issue

* nit fixes

* add exemptions

* nit fixes

* nit fixes

* nit fixes

* add remaining tests for all cases

* nit fixes

* nit fixes

Co-authored-by: Sparsh Agrawal <sparsh@Sparshs-MacBook-Air.local>
BenHenning pushed a commit that referenced this issue Aug 16, 2021
@Sparsh1212
Fix #3318: Add check to ensure all todos are addressed corresponding …
2da95a5 
…to the closed issue (#3629)

* Fix #3291: Add check for XML syntax correctness

* nit fixes

* Introduce XML syntax check in static checks workflow

* Fix #3292: Add check for test files presence for prod files

* Make nit suggestions

* Make nit suggestions

* Make nit suggestions

* Fix #3300: Add check for accessibility labels for activities

* Add CI check for label presence for activities

* Add ScriptConstants file to exemptions test list

* Test if: always()

* Revert "Test if: always()"

This reverts commit b72e419

* Add if: always()

* Add if: always()

* Add if: always()

* Apply review suggestions on PR

* Make review suggestions from regex pattern checks

* Implement review suggestions based on #3340

* Refactor PR as per feedback recieved

* Implement feedback suggestions

* Implement review suggestions

* Implement review suggestions

* Implement review suggestions

* Implement review suggestions

* nits

* Nit fixes

* Nit fixes

* Nit fixes

* Implement feedback suggestions as per #3340

* nit fix

* nit fix

* nit fix

* nit fix

* Review suggestions part 1

* Implement review suggestions part 2

* nit fixes

* update static_checks

* add test to repository file

* nit fix

* nit fix

* nit fix

* Do review suggestions

* Implement review suggestions

* Implement review suggestions

* nit fix

* Implement review suggestions

* Add Ben as a codeowner for the ScriptExemptions file

* bazel files nit fix

* Introduce a library for the regex assets

* Make directory structure same as that of #3374

* Make directory structure similar to #3374

* add new files to test file script exemptions and nit fixes

* diable ktlint max-line-length

* disable ktlint-max-line

* disable ktlint max-length

* remove testonly attribute from tests

* add new files to script exemptions

* nit fix

* nit fix

* nit fix

* Apply review suggestions

* ktlint fix

* nit fix

* Apply nit fixes

* Apply nit fixes

* Remove script constants

* nit fix

* add todo

* add todo

* nit fixes

* add test

* add testOnly

* nit fixes

* nit fix

* nit fixes

* nit fixes

* nit fixes

* nit fixes

* fix textproto file

* add exemptions to textproto

* sort failures lexicographically

* add new files to exemption list

* nit fixes

* nit fixes

* add kdocs

* nit fix

* nit fix

* Trigger CI failure exclusively

* Revert CI check failure

* Fix #3340: Create a script to ensure KDoc presence

* Add initial tests

* Add more tests and add documentation

* nit fix

* nit fix

* nit fix

* nit fix

* Add more files to kdoc exemptions

* Implementation part 1

* add exemption proto for todos

* nit fixes

* delete open issues

* nit fixes

* nit fixes

* Add redundant exemptions check

* rectify static_checks

* Remove duplicate proto libraries

* nit fixes

* nit fixes and add redundant exemptions check to script

* nit fixes

* add activity to exemption

* nit fixes

* nit fixes

* nit fixes

* nit fixes

* revamption part 1

* nit fixes

* update branch

* Revamped approach

* nit fixes

* add kdocs

* delete open_issues.json

* Fix #3317: Update old todos

* nit fixes

* Remove resolved todos

* Repurpose todos stage 1

* Repurpose todos stage 2

* Fix #3318: Add check to ensure all todos of closed issue are resolved

* nit fixes

* updating todos part 3

* add tests

* update more todos

* add network module

* update todo no. 322

* correct if condition in workflow

* Remove unused imports

* Add duplicate comment check condition

* nit fixes

* Correct exit code

* Revert "Remove unused imports"

This reverts commit 65ee6e9.

* Revert "update todo no. 322"

This reverts commit c150cdc.

* Repurpose no. 322

* nit fixes

* replace issue number for backend model todo

* add tests

* link new filed issue

* nit fixes

* add exemptions

* nit fixes

* nit fixes

* nit fixes

* nit fixes

* nit fixes

* add remaining tests for all cases

* nit fixes

* nit fixes

* nit fixes

Co-authored-by: Sparsh Agrawal <sparsh@Sparshs-MacBook-Air.local>
BenHenning pushed a commit that referenced this issue Aug 17, 2021
@Sparsh1212
Improve error messages (#3678)
6a859c1 
* Make nit suggestions

* Make nit suggestions

* Fix #3300: Add check for accessibility labels for activities

* Add CI check for label presence for activities

* Add ScriptConstants file to exemptions test list

* Test if: always()

* Revert "Test if: always()"

This reverts commit b72e419

* Add if: always()

* Add if: always()

* Add if: always()

* Apply review suggestions on PR

* Make review suggestions from regex pattern checks

* Implement review suggestions based on #3340

* Refactor PR as per feedback recieved

* Implement feedback suggestions

* Implement review suggestions

* Implement review suggestions

* Implement review suggestions

* Implement review suggestions

* nits

* Nit fixes

* Nit fixes

* Nit fixes

* Implement feedback suggestions as per #3340

* nit fix

* nit fix

* nit fix

* nit fix

* Review suggestions part 1

* Implement review suggestions part 2

* nit fixes

* update static_checks

* add test to repository file

* nit fix

* nit fix

* nit fix

* Do review suggestions

* Implement review suggestions

* Implement review suggestions

* nit fix

* Implement review suggestions

* Add Ben as a codeowner for the ScriptExemptions file

* bazel files nit fix

* Introduce a library for the regex assets

* Make directory structure same as that of #3374

* Make directory structure similar to #3374

* add new files to test file script exemptions and nit fixes

* diable ktlint max-line-length

* disable ktlint-max-line

* disable ktlint max-length

* remove testonly attribute from tests

* add new files to script exemptions

* nit fix

* nit fix

* nit fix

* Apply review suggestions

* ktlint fix

* nit fix

* Apply nit fixes

* Apply nit fixes

* Remove script constants

* nit fix

* add todo

* add todo

* nit fixes

* add test

* add testOnly

* nit fixes

* nit fix

* nit fixes

* nit fixes

* nit fixes

* nit fixes

* fix textproto file

* add exemptions to textproto

* sort failures lexicographically

* add new files to exemption list

* nit fixes

* nit fixes

* add kdocs

* nit fix

* nit fix

* Trigger CI failure exclusively

* Revert CI check failure

* Fix #3340: Create a script to ensure KDoc presence

* Add initial tests

* Add more tests and add documentation

* nit fix

* nit fix

* nit fix

* nit fix

* Add more files to kdoc exemptions

* Implementation part 1

* add exemption proto for todos

* nit fixes

* delete open issues

* nit fixes

* nit fixes

* Add redundant exemptions check

* rectify static_checks

* Remove duplicate proto libraries

* nit fixes

* nit fixes and add redundant exemptions check to script

* nit fixes

* add activity to exemption

* nit fixes

* nit fixes

* nit fixes

* nit fixes

* revamption part 1

* nit fixes

* update branch

* Revamped approach

* nit fixes

* add kdocs

* delete open_issues.json

* Fix #3317: Update old todos

* nit fixes

* Remove resolved todos

* Repurpose todos stage 1

* Repurpose todos stage 2

* Fix #3318: Add check to ensure all todos of closed issue are resolved

* nit fixes

* updating todos part 3

* add tests

* update more todos

* add network module

* update todo no. 322

* correct if condition in workflow

* Remove unused imports

* Add duplicate comment check condition

* nit fixes

* Correct exit code

* Revert "Remove unused imports"

This reverts commit 65ee6e9.

* Revert "update todo no. 322"

This reverts commit c150cdc.

* Repurpose no. 322

* nit fixes

* replace issue number for backend model todo

* add tests

* link new filed issue

* nit fixes

* add exemptions

* nit fixes

* nit fixes

* nit fixes

* nit fixes

* nit fixes

* add remaining tests for all cases

* point error messages to wiki

* nit fixes

* nit fixes

* nit fixes

* nit fixes

* log check medication only once

* reference exact urls

* correct flaky test

Co-authored-by: Sparsh Agrawal <sparsh@Sparshs-MacBook-Air.local>
@BenHenning BenHenning added TODO: need task force Z-ibt Temporary label for Ben to keep track of issues he's triaged. and removed TODO: need task force labels Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sparsh1212 Sparsh1212

Labels
Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3300: Add check for accessibility label for activities oppia/oppia-android
2 participants
@BenHenning @Sparsh1212