Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4608 : [Developer Video] How to use Talkback - screen reader and what does its output mean? #5148

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fix #4608 : [Developer Video] How to use Talkback - screen reader and what does its output mean? #5148

merged 1 commit into from
Sep 12, 2023

Conversation

MohitGupta121
Copy link
Member

@MohitGupta121 MohitGupta121 commented Sep 10, 2023 •
edited
Loading

Explanation

Fix #4608 : [Developer Video] How to use Talkback - screen reader and what does its output mean?

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

@MohitGupta121 MohitGupta121 requested review from a team as code owners September 10, 2023 17:21
@MohitGupta121 MohitGupta121 requested review from BenHenning and adhiamboperes and removed request for BenHenning September 10, 2023 17:23
MohitGupta121
MohitGupta121 commented Sep 10, 2023
View reviewed changes
Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenHenning @adhiamboperes PTAL, Thanks!

adhiamboperes
adhiamboperes approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@oppiabot
Copy link

oppiabot bot commented Sep 12, 2023

Unassigning @adhiamboperes since they have already approved the PR.

@adhiamboperes adhiamboperes merged commit 5e74b84 into oppia:develop Sep 12, 2023
26 checks passed
@MohitGupta121 MohitGupta121 deleted the talkback_dev_video branch September 12, 2023 17:41
@adhiamboperes adhiamboperes mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhiamboperes adhiamboperes adhiamboperes approved these changes

@BenHenning BenHenning Awaiting requested review from BenHenning

Assignees

@BenHenning BenHenning

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Developer Video] How to use Talkback - screen reader and what does its output mean?
3 participants
@MohitGupta121 @adhiamboperes @BenHenning