-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #10474: Enables strict typescript checks for some files - (2.4) #13459
Conversation
some title
merged-with-develop
@vojtechjelinek PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the minor changes in one codeowner file!
Unassigning @DubeySandeep since they have already approved the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Left a few comments.
core/templates/domain/collection/guest-collection-progress.service.ts
Outdated
Show resolved
Hide resolved
core/templates/domain/creator_dashboard/creator-dashboard-backend-api.service.ts
Show resolved
Hide resolved
...lates/pages/exploration-editor-page/feedback-tab/services/thread-data-backend-api.service.ts
Outdated
Show resolved
Hide resolved
...lates/pages/exploration-editor-page/feedback-tab/services/thread-data-backend-api.service.ts
Outdated
Show resolved
Hide resolved
@@ -226,8 +237,9 @@ export class ThreadDataBackendApiService { | |||
}); | |||
} | |||
|
|||
// A thread will be null if threadId is invalid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, okay, but then can we make sure that in the places where we set threadsById
, it is not missing the thread IDs?
@vojtechjelinek PTAL |
Hi @mridul-netizen. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks! |
Unassigning @srijanreddy98 since they have already approved the PR. |
@vojtechjelinek PTAL! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Few last comments in one file, feel free to do this file in a separate PR if you want to get the rest of the files to be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Overview
Essential Checklist
Proof that changes are correct
PR Pointers
Files Covered
PasteBin to Errors - link