Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #10474: Enables strict typescript checks for some files - (2.4) #13459

Merged
merged 103 commits into from
Aug 12, 2021

Conversation

mridul-netizen
Copy link
Contributor

@mridul-netizen mridul-netizen commented Jul 22, 2021

Overview

  1. This PR fixes or fixes part of Make typescript checks strict #10474 .
  2. This PR does the following: [Make Typescript checks strict for some files]

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

Proof that changes are correct

image

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.
  • Oppiabot can assign anyone for review/help if you leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL"
  • Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

Files Covered

 

1. "core/templates/pages/exploration-editor-page/services/user-exploration-permissions.service.ts",
2. "core/templates/pages/exploration-editor-page/services/user-exploration-permissions.service.spec.ts",
3. "core/templates/pages/exploration-editor-page/services/state-tutorial-first-time.service.ts",
4. "core/templates/pages/exploration-editor-page/services/state-tutorial-first-time.service.spec.ts",
5. "core/templates/services/generate-content-id.service.ts",
6. "core/templates/services/generate-content-id.service.spec.ts",
7. "core/templates/base-components/base-content.component.ts",
8. "core/templates/base-components/base-content.component.spec.ts",",
9. "core/templates/pages/admin-page/services/admin-data.service.ts",
10. "core/templates/pages/admin-page/services/admin-data.service.spec.ts",
11. "core/templates/expressions/expression-interpolation.service.ts",
12. "core/templates/expressions/expression-interpolation.service.spec.ts",
13. "core/templates/domain/improvements/successive-incorrect-answers-task.model.ts",
14. "core/templates/domain/improvements/successive-incorrect-answers-task.model.spec.ts",
15. "core/templates/domain/improvements/ineffective-feedback-loop-task.model.ts",
16. "core/templates/domain/improvements/ineffective-feedback-loop-task.model.spec.ts",
17. "core/templates/domain/exploration/exploration-id-validation.service.ts",
18. "core/templates/domain/exploration/exploration-id-validation.service.spec.ts", 
19. "core/templates/domain/topic/creator-topic-summary.model.ts",
20. "core/templates/domain/topic/creator-topic-summary.model.spec.ts",
21. "core/templates/domain/creator_dashboard/creator-dashboard-backend-api.service.ts",
22. "core/templates/domain/creator_dashboard/creator-dashboard-backend-api.service.spec.ts",
23. "core/templates/domain/collection/guest-collection-progress.service.ts",
24. "core/templates/domain/collection/guest-collection-progress.service.spec.ts",
25. "core/templates/services/navigation.service.ts"",
26. "core/templates/services/navigation.service.spec.ts",

PasteBin to Errors - link

@mridul-netizen
Copy link
Contributor Author

@vojtechjelinek PTAL

Copy link
Member

@DubeySandeep DubeySandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the minor changes in one codeowner file!

@oppiabot
Copy link

oppiabot bot commented Aug 9, 2021

Unassigning @DubeySandeep since they have already approved the PR.

Copy link
Member

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left a few comments.

@@ -226,8 +237,9 @@ export class ThreadDataBackendApiService {
});
}

// A thread will be null if threadId is invalid.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, okay, but then can we make sure that in the places where we set threadsById, it is not missing the thread IDs?

@vojtechjelinek vojtechjelinek removed their assignment Aug 9, 2021
@mridul-netizen
Copy link
Contributor Author

@vojtechjelinek PTAL

@oppiabot
Copy link

oppiabot bot commented Aug 10, 2021

Hi @mridul-netizen. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

@oppiabot
Copy link

oppiabot bot commented Aug 10, 2021

Unassigning @srijanreddy98 since they have already approved the PR.

@mridul-netizen
Copy link
Contributor Author

@vojtechjelinek PTAL!

Copy link
Member

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Few last comments in one file, feel free to do this file in a separate PR if you want to get the rest of the files to be merged.

@vojtechjelinek vojtechjelinek removed their assignment Aug 11, 2021
Copy link
Member

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants