Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5623 Move server launch to python #5657

Merged
merged 5 commits into from
Sep 17, 2018
Merged

Fix #5623 Move server launch to python #5657

merged 5 commits into from
Sep 17, 2018

Conversation

LanJosh
Copy link
Contributor

@LanJosh LanJosh commented Sep 15, 2018

Explanation

Fix #5623 Removes the piping in gulp to start the app devserver. Retains the watch functionality in gulp.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes.
  • The PR explanation includes the words "Fixes #bugnum: ...".
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR follows the style guide.
  • The PR is assigned to an appropriate reviewer.

@LanJosh LanJosh requested a review from apb7 as a code owner September 15, 2018 23:33
seanlip
seanlip approved these changes Sep 16, 2018
View reviewed changes
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LanJosh! Just one minor thing, but no objections. Glad to see we're getting rid of so much stuff.

@apb7 can you also review this before it goes in please? Thanks! (Aim is to remove gulp in general so we have less things we're depending on in the scripts.)

scripts/start.sh Outdated
($NODE_PATH/bin/node $NODE_MODULE_DIR/gulp/bin/gulp.js start_devserver --prod_env=$FORCE_PROD_MODE --gae_devserver_path=$GOOGLE_APP_ENGINE_HOME/dev_appserver.py --clear_datastore=$CLEAR_DATASTORE_ARG --enable_console=$ENABLE_CONSOLE_ARG)&

if ! [[ "$FORCE_PROD_MODE" == "True" ]]; then
($NODE_PATH/bin/node $NODE_MODULE_DIR/gulp/bin/gulp.js watch)&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deindent by 2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@hoangviet1993
Copy link
Contributor

@LanJosh Do we still need gulp at all now that we are using gcloud's dev_appserver.py?

@LanJosh
Copy link
Contributor Author

LanJosh commented Sep 17, 2018

@hoangviet1993 There is still the watch functionality being used by gulp currently. I believe I'll be able to remove it in a later PR and replace it with something already in our stack.

@seanlip
Copy link
Member

seanlip commented Sep 17, 2018

Thanks @LanJosh! LGTM.

@seanlip seanlip merged commit 162dfe9 into oppia:develop Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanlip seanlip seanlip approved these changes

@apb7 apb7 Awaiting requested review from apb7

Assignees

@seanlip seanlip

Labels
PR: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LanJosh @hoangviet1993 @seanlip