Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checks to ensure that a "changelog" label is applied on every PR #19

Closed
nithusha21 opened this issue Feb 17, 2019 · 0 comments · Fixed by #37
Closed

Add checks to ensure that a "changelog" label is applied on every PR #19

nithusha21 opened this issue Feb 17, 2019 · 0 comments · Fixed by #37
Assignees
@apb7
Labels
enhancement New feature or request

Comments

@nithusha21
Copy link

nithusha21 commented Feb 17, 2019 •
edited by apb7
Loading

We would like any PR that is merged into develop to have a "changelog: -type-" label. This is to help organize the changelog easily during releases.

PRs must contain exactly one changelog label, and the bot auto-close the PR if no label is found. It will leave a top-level comment asking the PR author to add a changelog label before reopening the PR.
@apb7 apb7 added the enhancement New feature or request label Feb 20, 2019
@apb7 apb7 self-assigned this Jul 26, 2019
This was referenced Jul 26, 2019
Merged
Closed
@apb7 apb7 closed this as completed in #37 Jul 26, 2019
apb7 added a commit that referenced this issue Jul 26, 2019
@apb7
Fix #34: Assigns the corresponding project owner for the first review…
fcd2f44 
… of a PR and Fix #19: Add check to ensure all PRs have changelog labels (#37)

* Initial work

* Change indentation to 2 spaces

* Fixes

* Add spaces and modify closing message

* Modify if condition

* Space after if and improve message

* Add validation checks and changelog label checks

* Reorder trim()

* Review comments

* Changes to the workflow

* Fixes

* Review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apb7 apb7

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@nithusha21 @apb7