Fix #205: Fails CI when a don't merge label get added on a pull request. #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vojtechjelinek
requested changes
May 15, 2021
constants.js
Outdated
| @@ -17,8 +17,8 @@ const openEvent = 'opened'; | |||
| const openEventGithubActions = 'pull_request_target_opened'; | |||
| const reopenEventGithubActions = 'pull_request_target_reopened'; | |||
| const reopenEvent = 'pull_request_reopened'; | |||
| const unlabelEvent = 'unlabeled'; | |||
| const PRLabelEvent = 'labeled'; | |||
| const unlabelEvent = 'pull_request_unlabeled'; | |||
There was a problem hiding this comment.
Suggested change
| const unlabelEvent = 'pull_request_unlabeled'; | |
| const PRUnlabelEvent = 'pull_request_unlabeled'; |
actions/src/dispatcher.js
Outdated
| @@ -40,6 +41,12 @@ module.exports = { | |||
| case constants.claCheckGithubAction: | |||
| await claCheckGithubActionModule.claCheckGithubAction(); | |||
| break; | |||
| case constants.prLabelCheck: | |||
| await pRLabelsModule.checkLabels(); | |||
There was a problem hiding this comment.
Suggested change
| await pRLabelsModule.checkLabels(); | |
| await PRLabelsModule.checkLabelAdded(); |
actions/src/dispatcher.js
Outdated
| await pRLabelsModule.checkLabels(); | ||
| break; | ||
| case constants.dontMergeLabelCheck: | ||
| await pRLabelsModule.checkUnLabeled(); |
There was a problem hiding this comment.
Suggested change
| await pRLabelsModule.checkUnLabeled(); | |
| await PRLabelsModule.checkLabelRemoved(); |
|
Unassigning @vojtechjelinek since the review is done. |
|
Hi @jameesjohn, it looks like some changes were requested on this pull request by @vojtechjelinek. PTAL. Thanks! |
|
Hi @jameesjohn. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks! |
|
@jameesjohn Is this ready for review? |
…merge-label-action
|
Yes @vojtechjelinek. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes #205: Fails CI when a don't merge label gets added on a pull request.
This PR has been tested at jameesjohn/comment-on-pr#51
Checklist