Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Part Of N/A: Ensures that bot adds 'PR:Affects Datastore Label' when a new cron job is added #268

Merged
merged 6 commits into from
May 18, 2021

Conversation

mridul-netizen
Copy link
Contributor

@mridul-netizen mridul-netizen commented May 13, 2021

Explanation

Ensures that bot adds 'PR:Affects Datastore Label' when a new cron job is added

Checklist

  • I have successfully deployed my own instance of Oppiabot.
    • You can find instructions for doing this here.
  • I have manually tested all the changes made in this PR following the manual tests matrix.

@mridul-netizen
Copy link
Contributor Author

@jameesjohn PTAL

@jameesjohn jameesjohn self-requested a review May 16, 2021 08:52
Copy link
Contributor

@jameesjohn jameesjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks, @mridul-netizen!

Revert the change to actions_build/index.js.

@mridul-netizen
Copy link
Contributor Author

LGTM!
Thanks, @mridul-netizen!

Revert the change to actions_build/index.js.

@jameesjohn Done,PTAL

@oppiabot oppiabot bot assigned jameesjohn and unassigned mridul-netizen May 16, 2021
@oppiabot
Copy link

oppiabot bot commented May 16, 2021

Unassigning @mridul-netizen since a re-review was requested. @mridul-netizen, please make sure you have addressed all review comments. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants