Fix #291: Add more features to oppia android #292
Conversation
| @@ -21,6 +21,9 @@ const pullRequest = require('../fixtures/pullRequestPayload.json').payload | |||
| .pull_request; | |||
| const CODE_OWNERS_FILE_URL = | |||
| 'https://raw.githubusercontent.com/oppia/oppia/develop/.github/CODEOWNERS'; | |||
| const OPPIA_ANDROID_CODE_OWNERS_FILE_URL = | |||
There was a problem hiding this comment.
Rename CODE_OWNERS_FILE_URL to OPPIA_CODE_OWNERS_FILE_URL
|
Assigning @vojtechjelinek for code owner reviews. Thanks! |
| [reopenEvent]: [], | ||
| [openEventGithubActions]: [claCheckGithubAction], | ||
| [reopenEventGithubActions]: [claCheckGithubAction], | ||
| [PRLabelEvent]: [], | ||
| [synchronizeEvent]: [], | ||
| [closeEvent]: [], | ||
| [closeEvent]: [updateWithDevelopCheck], |
There was a problem hiding this comment.
Should we update this part too? (since Android has different wiki)
| @@ -63,13 +63,13 @@ const dontMergeLabelCheck = 'dont-merge-label-check'; | |||
| const checksWhitelist = { | |||
| // eslint-disable-next-line quote-props | |||
| 'oppia-android': { | |||
| [openEvent]: [claCheck], | |||
| [openEvent]: [claCheck, codeOwnerCheck], | |||
There was a problem hiding this comment.
What does Oppiabot check for here? I'm mainly wondering how it will differ from the existing check already enabled in Oppia Android: https://github.com/oppia/oppia-android/blob/develop/.github/workflows/static_checks.yml#L19 (which uses https://github.com/mszostok/codeowners-validator).
|
Just checking, @jameesjohn are you still working on this? Hoping to utilize this feature soon, so it'd be really helpful to better understand your planning ETA for this PR. Please do let me know if there's anything that I can help out with, too. |
|
@jameesjohn Any update here? |
Explanation
Fixes #291:
Enables Post Merge Sync for oppia android.
Enables Codeowner change check for oppia-android.
Checklist