Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #304: Add check for hotfix label #305

Merged
merged 20 commits into from
Apr 13, 2022

Conversation

ankita240796
Copy link
Contributor

@ankita240796 ankita240796 commented Mar 31, 2022

Explanation

Fixes #304: Adds a check for when hotfix label is added so that release team is ping and the PR is brought to their attention.

Checklist

  • I have successfully deployed my own instance of Oppiabot.
    • You can find instructions for doing this here.
  • I have manually tested all the changes made in this PR following the manual tests matrix.

Copy link
Member

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One nit and on big picture comment.

lib/checkPullRequestLabels.js Outdated Show resolved Hide resolved
ankita240796 and others added 2 commits April 12, 2022 16:03
Co-authored-by: Vojtěch Jelínek <vojtech.jelinek@hey.com>
@ankita240796 ankita240796 removed their assignment Apr 12, 2022
@ankita240796
Copy link
Contributor Author

Hi @vojtechjelinek, I have addressed the comments, PTAL. Thanks!

Copy link
Member

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oppiabot
Copy link

oppiabot bot commented Apr 13, 2022

Unassigning @vojtechjelinek since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Apr 13, 2022
@ankita240796
Copy link
Contributor Author

Hi @seanlip @vojtechjelinek can we please merge this one? Thanks!

@vojtechjelinek vojtechjelinek merged commit fb0a435 into oppia:master Apr 13, 2022
@ankita240796 ankita240796 deleted the hotfix-update branch April 14, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oppiabot should assign release coordinator on addition of hotfix labels
2 participants