Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show Fink version in Footer #2799

Merged
merged 9 commits into from
May 21, 2024

Conversation

NiklasBuchfink
Copy link
Member

@NiklasBuchfink NiklasBuchfink commented May 17, 2024

This PR adds:

  • a dropdown to the Fink footer containing:
    • shorted commit hash (with GitHub link)
    • the sdk version
    • the lix client version
  • a version.json file that contains the data
  • a GitHub action that updates a file if there was a change in "inlang/source-code/editor/*"

How it looks in Fink:
Bildschirm­foto 2024-05-17 um 18 52 24

Test run of the action in repo fork:
NiklasBuchfink@b189d03

Related ticket:
https://linear.app/opral/issue/FINK-18/show-fink-version-in-ui

Copy link

changeset-bot bot commented May 17, 2024

⚠️ No Changeset found

Latest commit: a2da7d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@samuelstroschein samuelstroschein temporarily deployed to niklasbuchfink/fink-18-show-fink-version-in-ui - opral-website PR #2799 May 17, 2024 16:10 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to niklasbuchfink/fink-18-show-fink-version-in-ui - badge-service PR #2799 May 17, 2024 16:10 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to niklasbuchfink/fink-18-show-fink-version-in-ui - inlang-manage PR #2799 May 17, 2024 16:10 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to niklasbuchfink/fink-18-show-fink-version-in-ui - git-proxy PR #2799 May 17, 2024 16:10 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to niklasbuchfink/fink-18-show-fink-version-in-ui - inlang-website PR #2799 May 17, 2024 16:10 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to niklasbuchfink/fink-18-show-fink-version-in-ui - fink-editor PR #2799 May 17, 2024 17:02 — with Render Destroyed
@NiklasBuchfink NiklasBuchfink marked this pull request as ready for review May 17, 2024 17:07
@samuelstroschein samuelstroschein temporarily deployed to niklasbuchfink/fink-18-show-fink-version-in-ui - opral-website PR #2799 May 21, 2024 13:38 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to niklasbuchfink/fink-18-show-fink-version-in-ui - inlang-website PR #2799 May 21, 2024 13:38 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to niklasbuchfink/fink-18-show-fink-version-in-ui - inlang-manage PR #2799 May 21, 2024 13:38 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to niklasbuchfink/fink-18-show-fink-version-in-ui - git-proxy PR #2799 May 21, 2024 13:38 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to niklasbuchfink/fink-18-show-fink-version-in-ui - badge-service PR #2799 May 21, 2024 13:38 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to niklasbuchfink/fink-18-show-fink-version-in-ui - fink-editor PR #2799 May 21, 2024 15:02 — with Render Destroyed
Copy link
Contributor

@janfjohannes janfjohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx :)

Copy link
Contributor

@jldec jldec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks @NiklasBuchfink
LGTM

@NiklasBuchfink NiklasBuchfink merged commit 0ffb94f into main May 21, 2024
3 checks passed
@NiklasBuchfink NiklasBuchfink deleted the niklasbuchfink/fink-18-show-fink-version-in-ui branch May 21, 2024 15:52
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants