This repository has been archived by the owner on Oct 21, 2019. It is now read-only.
Remove opsdroid pointer from methods, add opsdroid param to __init__ #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @FabioRosado , sorry I've taken so long to get to this. This looks good to me, but we've now included this change in opsdroid/opsdroid#731 to port the connector into core, so I'll close this. Thanks anyway :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
I have merged the PR Refactor opsdroid pointer and that PR will brake this connector.
This short PR will fix the issues - but I haven't tested the connector with matrix. Hope this is alright 😄 👍