Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server Status due to Ping #268

Closed
JoshKeegan opened this issue Jun 27, 2017 · 1 comment
Closed

Server Status due to Ping #268

JoshKeegan opened this issue Jun 27, 2017 · 1 comment

Comments

@JoshKeegan
Copy link

Hi,
We're just starting to use OpServer in production; so first of all, thanks it's looking great!

One small thing we've noticed though is that all of the servers we're monitoring (so far) apart from the one running bosun show with a warning:
image

Looking in the code it seems to be in BosunDataProvider.GetNodeStatus they're being marked as unreachable by:

if (host.ICMPData?.Values.All(p => p.TimedOut) == true)
    return NodeStatus.Unreachable;

This makes sense as we don't operate internal DNS and so server hostnames won't be resolved to IPs & Bosun won't be able to ping the servers.
Is there a setting to disable no ping producing a warning?

For now, I expect we'll just comment those lines.
Cheers,
Josh

NickCraver added a commit that referenced this issue Nov 13, 2017
This adds an IgnorePing option for Bosun which doesn't care about ICMP status if true.
@NickCraver
Copy link
Member

I've pushed a new option in latest to ignore the ping status, like this:

  "providers": {
    "bosun": {
      "host": "...",
      "apiKey": "...",
      "ignorePing": true
    }

Please let me know if you have any issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants