Change date location to UTC before formatting #113
Closed
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakhar-mudaiya
approved these changes
Nov 4, 2022
|
Thanks for the approval, @prakhar-mudaiya ! |
|
@prakhar-mudaiya what is the process to get this merged, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the time format
2006-01-02T15:04:05.000Zis used instead of the idiomatictime.RFC3339ortime.RFC3339Nano.This does not work well for different time zones or daylights saving time (playground link).
One solution would be to change the format to
time.RFC3339Nano, however there is a risk that the API won't handle the different format.Instead, we should at least make sure that the time is set to the UTC location.