Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set generate_profile to false for pools #3779

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Jul 8, 2024

Due to how the profiles are generated without changing these attributes it's not possible to load the pools within the frontend.

Replaces #3762.

Due to how the profiles are generated without changing these attributes
it's not possible to load the pools within the frontend.
@ogenstad ogenstad added the type/bug Something isn't working as expected label Jul 8, 2024
@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Jul 8, 2024
Copy link

codspeed-hq bot commented Jul 8, 2024

CodSpeed Performance Report

Merging #3779 will degrade performances by 33.12%

Comparing pog-avoid-profile-on-pools (029ad1e) with develop (1fdf808)

Summary

❌ 1 regressions
✅ 9 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark develop pog-avoid-profile-on-pools Change
test_load_node_to_db_node_schema 50 ms 74.8 ms -33.12%

@ogenstad ogenstad marked this pull request as ready for review July 8, 2024 09:40
@ogenstad ogenstad merged commit a64dc06 into release-0.15 Jul 8, 2024
44 of 45 checks passed
@ogenstad ogenstad deleted the pog-avoid-profile-on-pools branch July 8, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent) type/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants