Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate writes when badger transaction full #487

Merged
merged 2 commits into from
Oct 1, 2021

Conversation

awfm9
Copy link
Collaborator

@awfm9 awfm9 commented Oct 1, 2021

Goal of this PR

Fixes #351 (third time's the charm!).

@awfm9 awfm9 requested review from Ullaakut and Maelkum October 1, 2021 10:06
@awfm9 awfm9 self-assigned this Oct 1, 2021
@awfm9 awfm9 changed the title Fix repeated badger operations in index writer Fix index writer repeating operations when badger transaction full Oct 1, 2021
@awfm9 awfm9 changed the title Fix index writer repeating operations when badger transaction full Fix duplicate writes when badger transaction full Oct 1, 2021
Copy link
Contributor

@Ullaakut Ullaakut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link
Contributor

@Maelkum Maelkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and the tests show no duplicates any more :)
🎉

@awfm9 awfm9 force-pushed the fix-repeated-badger-transactions branch from 5450654 to 5d6b858 Compare October 1, 2021 13:15
@awfm9 awfm9 merged commit dff48ac into master Oct 1, 2021
@Ullaakut Ullaakut deleted the fix-repeated-badger-transactions branch November 8, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indexer: investigate duplicate transactions
3 participants