Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Fixes #488
This PR imports
"github.com/dgraph-io/badger/v2/y"
in both indexer binaries, so that the metrics are exposed on the default HTTP handler. It also adds an HTTP server to both binaries which exposes the default handler (which is why it's given anil
handler).You can test this PR by running the indexer and making a
curl
call to<FLAG_METRICS>/debug/vars
, depending on what you set as the--metrics
parameter.FYI, here is the
init
function in badger's metrics package:The exposed metrics are expvar metrics, so in order to consume them with something like prometheus, you will need external tooling, such as prometheus-expvar-exporter.
Checklist