Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make optic token optional, only upload when token is set #29

Merged
merged 4 commits into from
Jun 8, 2023

Conversation

Alexandre-Herve
Copy link
Contributor

No description provided.

Copy link
Contributor

@niclim niclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to run yarn build to generate the build assets

We can also test this out before merging if you want to tag this branch with v1.0.8 + update some repo to use the tag

@notnmeyer
Copy link

notnmeyer commented Jun 8, 2023

very meta, but looks like this reformats to 4 spaces of indentation. monorail and optic both use 2 for ts. i don't particularly care, just calling out that departure.

edit: oh, i see prettier is complaining. i love how unhelpful "[warn] Code style issues found in the above file. Forgot to run Prettier?" is.

@Alexandre-Herve
Copy link
Contributor Author

Alexandre-Herve commented Jun 8, 2023

Well my editor doesn't seem to follow the project config, and also I ran yarn run format but the ci still complains -_- yarn lint passes locally as well, investigating

@Alexandre-Herve
Copy link
Contributor Author

Ok so since no .prettierrc or equivalent is defined in the project, prettier was looking at my ~/.prettierrc config, which differs from the default prettier config used on the ci. I'm adding a prettier block in package.json

@Alexandre-Herve Alexandre-Herve merged commit d1a9e5a into main Jun 8, 2023
@Alexandre-Herve Alexandre-Herve deleted the remove-token-check branch June 8, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants