-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make optic token optional, only upload when token is set #29
Conversation
0fc702d
to
bde9507
Compare
bde9507
to
ce7ffe9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll also need to run yarn build
to generate the build assets
We can also test this out before merging if you want to tag this branch with v1.0.8
+ update some repo to use the tag
very meta, but looks like this reformats to 4 spaces of indentation. monorail and optic both use 2 for ts. i don't particularly care, just calling out that departure. edit: oh, i see prettier is complaining. i love how unhelpful "[warn] Code style issues found in the above file. Forgot to run Prettier?" is. |
de269b0
to
58df2ae
Compare
Well my editor doesn't seem to follow the project config, and also I ran |
58df2ae
to
2fb143e
Compare
Ok so since no |
No description provided.