feat (audiences): Audience combinations #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… oakbani/audience-match-types-project-config
… oakbani/audience-match-types-project-config
…ience-match-type-condition-evaluator-2
… oakbani/audience-match-types-project-config
… oakbani/audience-match-types-project-config
… oakbani/audience-match-types-project-config
Co-Authored-By: oakbani <owais.akbani92@gmail.com>
… oakbani/audience-match-types-project-config
oakbani
requested review from
aliabbasrizvi,
nchilada,
mikeproeng37 and
msohailhussain
nchilada
suggested changes
Dec 7, 2018
optimizely/helpers/audience.py
Outdated
| @@ -50,17 +29,34 @@ def is_user_in_experiment(config, experiment, attributes): | |||
| """ | |||
|
|
|||
| # Return True in case there are no audiences | |||
| if not experiment.audienceIds: | |||
| audience_conditions = experiment.getAudienceConditionsOrIds() | |||
| if not audience_conditions: | |||
There was a problem hiding this comment.
Nit: it'd be safer to perform an explicit check
if audience_conditions is None or audience_conditions == []:especially since the condition tree may be a single leaf node (an audience ID) and that leaf node could (theoretically) be ('').
optimizely/helpers/audience.py
Outdated
|
|
||
| eval_result = condition_tree_evaluator.evaluate( | ||
| audience_conditions, | ||
| lambda audienceId: evaluate_audience(audienceId) |
There was a problem hiding this comment.
Suggested change
| lambda audienceId: evaluate_audience(audienceId) | |
| evaluate_audience |
nchilada
approved these changes
Dec 11, 2018
tests/helpers_tests/test_audience.py
Outdated
|
|
||
| self.assertStrictFalse(audience.is_user_in_experiment(self.project_config, experiment, user_attributes)) | ||
|
|
||
| def test_is_user_in_experiment__evaluates_audience_Ids(self): |
There was a problem hiding this comment.
Nit: maybe delete the underscore in audience_Ids?
msohailhussain
changed the base branch from
oakbani/audience-match-types-project-config
to
master
oakbani
changed the base branch from
master
to
oakbani/audience-match-types-project-config
oakbani
changed the base branch from
oakbani/audience-match-types-project-config
to
master
…ience-combinations-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds support for audience combinations on experiments. If
experiment.audienceConditionsis present, it will be used as a condition tree where the leaf conditions are audience Ids.Test plan
Issues