feat(decision-listener): Incorporated new decision notification listener changes. #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliabbasrizvi
approved these changes
Apr 24, 2019
optimizely/helpers/enums.py
Outdated
| """ | ||
| ACTIVATE = "ACTIVATE:experiment, user_id, attributes, variation, event" | ||
| DECISION = "DECISION:type, user_id, attributes, decision_info" | ||
| TRACK = "TRACK:event_key, user_id, attributes, event_tags, event" | ||
|
|
||
|
|
||
| class DecisionInfoTypes(object): | ||
| EXPERIMENT = "experiment" | ||
| class DecisionNotificationTypes(object): |
There was a problem hiding this comment.
nit. Lets alphabetize class names here.
Also, conventionally we do single quotes for all strings.
optimizely/project_config.py
Outdated
| @@ -106,12 +106,19 @@ def __init__(self, datafile, logger, error_handler): | |||
| ) | |||
|
|
|||
| self.feature_key_map = self._generate_key_map(self.feature_flags, 'key', entities.FeatureFlag) | |||
|
|
|||
| # Hash containing experiment Ids that exist in any feature | |||
There was a problem hiding this comment.
nit. Dict and not hash.
Also, right message will be Dict containing map of experiment ID to feature ID ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
feature-testand project config method.