Fixing multiple issues in notification_center. #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliabbasrizvi
requested review from
thomaszurkan-optimizely,
mikeproeng37,
mjc1283 and
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
notification_center.NotificationCenterdid not have any unit tests for the class. All the related unit tests were absorbed in tests foroptimizely.Optimizely. This PR:test_notification_center.pyto introduce unit tests for theNotificationCenterclass.NotificationCenterclass. This includes fixing incorrect API names which have been marked as deprecated and we will discontinue support in the next major release.test_optimizely.pywhich were focusing on tests captured intest_notification_center.py.Test plan