Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Updating docs dependencies based on core dependencies #266

Merged
merged 1 commit into from
May 16, 2020
Merged

chore(deps): Updating docs dependencies based on core dependencies #266

merged 1 commit into from
May 16, 2020

Conversation

aliabbasrizvi
Copy link
Contributor

Updating it this way to avoid duplicating dependencies

@aliabbasrizvi aliabbasrizvi requested a review from a team as a code owner May 16, 2020 00:56
@aliabbasrizvi aliabbasrizvi removed their assignment May 16, 2020
yavorona
yavorona approved these changes May 16, 2020
View reviewed changes
Copy link
Contributor

@yavorona yavorona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.097% when pulling 99f8c1f on ali/update_reqs into 54661ca on master.

@aliabbasrizvi aliabbasrizvi merged commit d257be5 into master May 16, 2020
@aliabbasrizvi aliabbasrizvi deleted the ali/update_reqs branch May 16, 2020 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yavorona yavorona yavorona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aliabbasrizvi @coveralls @yavorona