Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix cryptography wheel build for pypy and pypy3 #318

Closed
wants to merge 2 commits into from

Conversation

oakbani
Copy link
Contributor

@oakbani oakbani commented Mar 1, 2021

Summary

Unit tests on Python pypy and pypy3 have been failing consistently for quite some time. On detailed investigation, cryptography package is required by the requests[security] module. Although the latest cryptography version does support pypy, it doesn't build for some reason.

Setting cryptography package to a static previous version revealed that Python 3.4 support has been dropped after cryptography 2.8. Therefore, in this PR we specify version bounds that support all of our supported python versions.

Test plan

All checks continue to pass.

Issues

@coveralls
Copy link

coveralls commented Mar 1, 2021

Coverage Status

Coverage remained the same at 95.883% when pulling 47b67cc on oakbani/fix-pypy into 5fefd2b on master.

@oakbani oakbani closed this Mar 1, 2021
@oakbani oakbani reopened this Mar 1, 2021
@Mat001
Copy link
Contributor

Mat001 commented Mar 1, 2021

@oakbani LGTM. Keep in mind that I had to rerun pypy3 unit tests 5 times before they passed. A single tests was failing (polling manager) until it passed (flakey?). I noticed that same test failed occasionally in previous builds but not sure if it's 4/5 runs or less flakey.

I doub't that cryptography version update causes that test to frequently fail...

@oakbani
Copy link
Contributor Author

oakbani commented Mar 2, 2021

@Mat001 Yeah, this flaky test has been always there. It's not related to this cryptography fix. This flaky test occurs more on the pypy versions as compared to other python versions. We should address this test in a separate PR

@Mat001 Mat001 mentioned this pull request Mar 3, 2021
@oakbani
Copy link
Contributor Author

oakbani commented Mar 8, 2021

Closing in favor of #320

@oakbani oakbani closed this Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants