Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: Remove mmh3 external dependency and use internal pymmh3 in place #362

Merged
merged 9 commits into from
Nov 3, 2021
Merged

enhancement: Remove mmh3 external dependency and use internal pymmh3 in place #362

merged 9 commits into from
Nov 3, 2021

Conversation

The-inside-man
Copy link
Contributor

@The-inside-man The-inside-man commented Oct 21, 2021 •
edited
Loading

Summary

  • Removal of mmh3 external dependency and update imports to use internal pymmh3 instead

Testing

  • FSC

Issues

  • "OASIS-7995"

@The-inside-man The-inside-man requested a review from a team as a code owner October 21, 2021 16:53
@The-inside-man The-inside-man removed the request for review from a team October 21, 2021 16:53
@The-inside-man The-inside-man marked this pull request as draft October 21, 2021 16:53
@coveralls
Copy link

coveralls commented Oct 21, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 96.088% when pulling 7d0ce97 on jbrown/lite-version-tests into 5420c7c on master.

@The-inside-man
Copy link
Contributor Author

@msohailhussain Looks like three of the libraries were able to be removed with no issues, the others had to stay since they were dependencies for other libraries. We should be able to release this or something along these lines as a light version of the python-sdk by changing a few fields in the setup.py file pre release. What are your thoughts?

@The-inside-man The-inside-man changed the title DO NOT REVIEW OR MERGE - changes for lite version TESTING ONLY enhancement: Remove mmh3 external dependency and use internal pymmh3 in place Oct 26, 2021
@The-inside-man The-inside-man marked this pull request as ready for review October 26, 2021 17:15
@The-inside-man
Copy link
Contributor Author

The-inside-man commented Nov 1, 2021 •
edited
Loading

This PR is in attention to issue: #232

Mat001
Mat001 approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all the tests pass and if FSC passes for older versions of Py then I think we're good.
LGTM

@The-inside-man
Copy link
Contributor Author

@msohailhussain Confirmed tests work on windows machine

@The-inside-man The-inside-man merged commit a1e31eb into master Nov 3, 2021
@The-inside-man The-inside-man deleted the jbrown/lite-version-tests branch November 3, 2021 17:59
@The-inside-man The-inside-man mentioned this pull request Nov 3, 2021
Closed
@GordonSo GordonSo mentioned this pull request Nov 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mat001 Mat001 Mat001 approved these changes

@msohailhussain msohailhussain Awaiting requested review from msohailhussain

@jaeopt jaeopt Awaiting requested review from jaeopt

Assignees

@The-inside-man The-inside-man

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@The-inside-man @coveralls @Mat001