Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix user overrides: merge overrides with current user attributes #131

Conversation

Sillhouette
Copy link

This pull request addresses the issue that is laid out by my colleague @dtothefp here: #120

It will merge the existing user attributes with the current user's attributes to prevent losing the user attributes that are set when the optimizely client is initialized.

@mikechu-optimizely
Copy link
Contributor

Thanks for relating this to @dtothefp 's Issue and putting in the coding for it.

I've related and upgraded the internal ticket (FSSDK-8652).

When you have a chance, please review the CONTRIBUTING.md and sign the linked Contributors License Agreement (CLA).

@Sillhouette
Copy link
Author

Thanks for relating this to @dtothefp 's Issue and putting in the coding for it.

I've related and upgraded the internal ticket (FSSDK-8652).

When you have a chance, please review the CONTRIBUTING.md and sign the linked Contributors License Agreement (CLA).

I've done that 👍

@junaed-optimizely
Copy link
Contributor

junaed-optimizely commented Nov 8, 2024

I have already given my thought on this here in the issue comment. I think the way we handle overrides are intended this way.

But its an interesting idea, and we might revisit it in future if required.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants