Add support to configure docker/clair timeouts #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
variables. Fixes #88
|
Actually there is one more improvement that came to my mind. With the current implementation it is not possible to disable the timeout at all. Since klar.go#L50 always ensures returning 0 (without a possibility to check if the env var has actually been set). Therefore, setting Another possibility would be to support golangs duration format so it's easier to specify timeouts with seconds (e.g. If your fine with those changes I can update the pull request. |
|
Thanks for contribution! Your suggestion sound reasonable, please go ahead if you like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support to configure clair (API v1) and docker timeouts using environment variables. Fixes #88