Updated URL parser to use NSDataDetector #142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated sample to showcase new URL pattern
|
Hi @taylanpince , the reason why we are not using NSDataDetector is because it is 2x slower than Regex (#40 (comment)). And since this component is heavily used in tables, the performance was heavily affected. I would rather prefer to polish the current Regex TBH |
|
Fair enough. Our use case is different and getting all kinds of links working is more important so we'Il keep working from our fork. Thanks! |
|
Thanks for your understanding @taylanpince ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed to support user-entered links such as google.com, but the current RegEx based approach was too complicated to support this. We switched to using an NSDataDetector instead, which supports a myriad of link types, auto-parses and converts them to a proper URL object. Updated approach falls back to the RegEx pattern if the data detector cannot be instantiated for any reason.