-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement log scale of parallel coordinate #627
Conversation
Codecov Report
@@ Coverage Diff @@
## main #627 +/- ##
==========================================
+ Coverage 56.40% 62.45% +6.04%
==========================================
Files 35 35
Lines 2193 2224 +31
==========================================
+ Hits 1237 1389 +152
+ Misses 956 835 -121
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
) | ||
const ticktext = tickvals.map((x) => `${Math.pow(10, x).toPrecision(3)}`) | ||
return { logValues, tickvals, ticktext } | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ticktext, | ||
} | ||
} else { | ||
// numerical and non-log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nit.
// numerical and non-log | |
// numerical and linear |
Or you can simply remove these comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! It works as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR. Please check my comment.
}) | ||
const minValue = Math.min(...logValues) | ||
const maxValue = Math.max(...logValues) | ||
const range = [minValue, maxValue] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both ends of ticks should be within the range.
const range = [minValue, maxValue] | |
const range = [Math.floor(minValue), Math.ceil(maxValue)] |
@not522 Thank you for reviewing. Could you check it again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Contributor License Agreement
This repository (
optuna-dashboard
) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
NA
Log axis if distribution is log scale for parallel coordinate plot
scripts