Split DataGrid component into two components #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-bata
force-pushed
the
split-datagrid-components
branch
from
5755b7e
to
d114696
Compare
c-bata
changed the title
c-bata
force-pushed
the
split-datagrid-components
branch
from
d114696
to
7632683
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #698 +/- ##
=======================================
Coverage 62.88% 62.88%
=======================================
Files 35 35
Lines 2250 2250
=======================================
Hits 1415 1415
Misses 835 835 ☔ View full report in Codecov by Sentry. |
|
@nabenabe0928 Could you review this PR? |
1 task
Comment on lines
+226
to
+230
| if (orderBy === null) { | ||
| onOrderByChange("asc") | ||
| } else { | ||
| onOrderByChange(orderBy === "desc" ? "asc" : "desc") | ||
| } |
There was a problem hiding this comment.
It could be simpler with this:
Suggested change
| if (orderBy === null) { | |
| onOrderByChange("asc") | |
| } else { | |
| onOrderByChange(orderBy === "desc" ? "asc" : "desc") | |
| } | |
| onOrderByChange(orderBy === "asc" ? "desc" : "asc" |
| <DataGridHeaderColumn<T> | ||
| key={column.label} | ||
| column={column} | ||
| orderBy={orderBy === columnIdx ? order : null} |
There was a problem hiding this comment.
Can we rename the orderBy in Line 54 to something like orderByColumnId as the name orderBy duplicates for two different roles?
| @@ -239,6 +187,76 @@ function DataGrid<T>(props: { | |||
| ) | |||
| } | |||
|
|
|||
| function DataGridHeaderColumn<T>(props: { | |||
There was a problem hiding this comment.
Could this name be better as this component is a header, but not column? (please correct me if I am wrong)
Suggested change
| function DataGridHeaderColumn<T>(props: { | |
| function DataGridColumnHeader<T>(props: { |
nabenabe0928
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
Follow-up #696
What does this implement/fix? Explain your changes.
This PR splits
DataGridcomponent into two components, DataGrid and DataGridHeaderColumn, making it easier to introduce #696.