Support numpy
scalars in Trial.user_attrs
#706
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor License Agreement
This repository (
optuna-dashboard
) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
This PR addresses the following TODO comment:
optuna-dashboard/optuna_dashboard/_cached_extra_study_property.py
Line 88 in cd2159e
What does this implement/fix? Explain your changes.
FrozenTrial
.np.integer
andnp.floating
as sortable values.Discussion
numpy
scalars can only stored inInMemoryStorage
since they are not JSON-serializable.I guess most of users use persistent storages such as
RDBStorage
andJournalFileStorage
with the dashboard, so the change might benefit limited number of users.Additional Context
Below is the code provided to verify the behavior described.
numpy-scalars-in-user-attrs.py