Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent layout shift with intermediate values plot #726

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

not522
Copy link
Member

@not522 not522 commented Dec 7, 2023

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

What does this implement/fix? Explain your changes.

The layout shift is occurring because the decision to display the plot of intermediate values is made during loading. This PR prevents the shift by replacing the plot last.

@c-bata c-bata self-assigned this Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9e314a9) 67.20% compared to head (885da8f) 67.20%.
Report is 22 commits behind head on main.

Files Patch % Lines
optuna_dashboard/_app.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #726   +/-   ##
=======================================
  Coverage   67.20%   67.20%           
=======================================
  Files          35       35           
  Lines        2293     2293           
=======================================
  Hits         1541     1541           
  Misses        752      752           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-bata c-bata merged commit e25d42e into optuna:main Dec 7, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants