Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests for JournalStorage #861

Merged
merged 6 commits into from
Apr 10, 2024

Conversation

porink0424
Copy link
Collaborator

@porink0424 porink0424 commented Apr 10, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

Follow up PR of #860

What does this implement/fix? Explain your changes.

  • Improved the parsing error handling in JournalStorage:
    • The implementation was designed so that even a single error line would cause the entire system to crash, but error lines can now be pushed into errors variables to prevent it.
  • Added tests for JournalStorage:
    • Checking studies including Infinity, -Infinity, NaN.
    • Checking if the system does not crash even when lines that cannot be parsed are included in the file.

Reference

Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@c-bata c-bata merged commit d0536a1 into optuna:main Apr 10, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants