Remove RedisStorage
#4156
Merged
Remove RedisStorage
#4156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
optuna.integration
Codecov Report
@@ Coverage Diff @@
## master #4156 +/- ##
==========================================
- Coverage 90.11% 89.86% -0.25%
==========================================
Files 162 161 -1
Lines 12734 12336 -398
==========================================
- Hits 11475 11086 -389
+ Misses 1259 1250 -9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@knshnb Could you review this PR? |
|
Let me unassign knshnb-san since he is busy. @not522 Could you review this PR? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The implementation of RedisStorage is a bit complex and code size is large since it is based on BaseStorage. RedisStorage has been found to have bugs mainly in concurrency
set_trial_state_valuesis not concurrent-safe (See Skiptest_pop_waiting_trial_thread_safeon RedisStorage #4119).WATCH <KEY NAME>though.)In Optuna v3.1, a brand-new Redis storage, which is based-on
JournalStorage, is introduced. It much simpler thanRedisStorageand improves maintainability as it is written in about 110 lines even after implemented a snapshot capability (#4102).Description of the changes
In this PR, I removed
RedisStoragesince experimental features can be removed without a deprecation process in Optuna’s development policy.