Fix a bug in _create_new_trial and refactor it
#5497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will add unittest(s) if possible; I assume it is not difficult and will be done today. The unittest(s) will confirm that the |
nabenabe0928
added
the
bug
nabenabe0928
added
code-fix
eukaryo
changed the title
_create_new_trial_create_new_trial
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
nabenabe0928
changed the title
_create_new_trial_create_new_trial and refactor it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I want to refactor
_create_new_trialI want
_create_new_trialto generate no empty trial_id when transaction processing fails.(note: I want to clarify by separating single issue in PR #5466 , which involves multiple issues and becomes complicated.)
Description of the changes
In the current implementation,
with _create_scoped_sessionis outside andwhileloop is inside, so if the transaction fails in_get_prepared_new_trial, Optuna retries without rollback of the precedingfind_or_raise_by_id. As a result, emptytrial_idcan be generated. (I confirmed the behaviour by a simple experiment that inserts a line raising an exception atrandomin_get_prepared_new_trial.)In the proposed implementation,
with _create_scoped_sessionis inside the for loop, so a rollback occurs against every fail of transaction.Note
In the current inplementation, only
sqlalchemy_exc.OperationalError:will be caught, and other exceptions are re-raised as is. I believe the proposed implementation does not change the behaviour.