Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rst docs #22

Merged
merged 4 commits into from
Apr 11, 2019
Merged

Fix rst docs #22

merged 4 commits into from
Apr 11, 2019

Conversation

AnjoMan
Copy link
Member

@AnjoMan AnjoMan commented Apr 11, 2019

turns out PyPi doesn't like it when two links have the same text

@AnjoMan
Copy link
Member Author

AnjoMan commented Apr 11, 2019

i tested it here https://test.pypi.org/project/corsons/

@coveralls
Copy link

Pull Request Test Coverage Report for Build 132

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.5%
Totals Coverage Status
Change from base Build 129: 0.0%
Covered Lines: 126
Relevant Lines: 144
💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 11, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 141

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.5%
Totals Coverage Status
Change from base Build 129: 0.0%
Covered Lines: 126
Relevant Lines: 144
💛 - Coveralls

veronicaguo
veronicaguo reviewed Apr 11, 2019
View reviewed changes
Copy link
Collaborator

@veronicaguo veronicaguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look great! Just had a comment on the example about property names.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
EmilyYLMa
EmilyYLMa reviewed Apr 11, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@veronicaguo veronicaguo merged commit 526c828 into master Apr 11, 2019
@etimberg etimberg deleted the fix-rst-docs branch October 27, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilyYLMa EmilyYLMa EmilyYLMa left review comments

@veronicaguo veronicaguo veronicaguo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnjoMan @coveralls @EmilyYLMa @veronicaguo