Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bacn fixes #23

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Bacn fixes #23

merged 1 commit into from
Apr 12, 2019

Conversation

AnjoMan
Copy link
Member

@AnjoMan AnjoMan commented Apr 11, 2019 •
edited
Loading

Found some more phase position mixups in the test data. thanks to @kdheepak for catching this in the first place!

@AnjoMan AnjoMan requested a review from EmilyYLMa April 11, 2019 16:10
@coveralls
Copy link

coveralls commented Apr 11, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 144

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.5%
Totals Coverage Status
Change from base Build 129: 0.0%
Covered Lines: 126
Relevant Lines: 144
💛 - Coveralls

@kdheepak
Copy link
Contributor

Awesome!

@EmilyYLMa EmilyYLMa merged commit 8d21445 into master Apr 12, 2019
@etimberg etimberg deleted the bacn-fixes branch October 27, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@EmilyYLMa EmilyYLMa Awaiting requested review from EmilyYLMa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AnjoMan @coveralls @kdheepak @etimberg @EmilyYLMa