Code Sample for spring_jdbc Getting started #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuassim
reviewed
May 12, 2022
|
|
||
| /* | ||
| DESCRIPTION | ||
| The code sample maps uses the jpaRepository to return |
There was a problem hiding this comment.
Can you rework this sentence?
Kuassim
reviewed
May 12, 2022
java/spring_jdbc_example/README.md
Outdated
|
|
||
| # Main Components of the Code | ||
|
|
||
| * TestController.java: Has one get mapping that uses StudentService to retrieve all the Students |
There was a problem hiding this comment.
Can you plz rework this sentence?
Kuassim
approved these changes
May 12, 2022
Kuassim
previously approved these changes
May 12, 2022
Made changes to readme.md and studentservice class description
Kuassim
approved these changes
May 19, 2022
gvenzl
requested changes
May 20, 2022
| # | ||
|
|
||
| spring.datasource.driver-class-name=oracle.jdbc.OracleDriver | ||
| spring.datasource.url=jdbc:oracle:thin:@adbps_medium?TNS_ADMIN=/Users/psong/Desktop/JDBC_vid_series/Wallet_ADBPS |
There was a problem hiding this comment.
This should be a placeholder just like we have for username and password.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the accompanying code sample for the spring jdbc getting started video.